Prevent error when updating an existing asset via WebDav by BlackbitDevs · Pull Request #1 · BlackbitDevs/pimcore

BlackbitDevs · 2022-04-04T13:32:39Z

In the $this->asset->save() call, the stream can get closed, which leads to a TypeError when trying to close the stream again.
The extra is_resource check prevents this.

This can be reproduced by trying to upload an asset twice:

➜  webdav curl --user "***" -D- -T 'testimage.jpg' 'https://demo.pimcore.fun/admin/asset/webdav/testimage.jpg'
HTTP/1.1 100 Continue

HTTP/1.1 201 Created
Date: Mon, 04 Apr 2022 13:26:00 GMT



➜  webdav curl --user "***" -D- -T 'testimage.jpg' 'https://demo.pimcore.fun/admin/asset/webdav/testimage.jpg'
HTTP/1.1 100 Continue

HTTP/1.1 500 Internal Server Error
Date: Mon, 04 Apr 2022 13:26:01 GMT


<?xml version="1.0" encoding="utf-8"?>
<d:error xmlns:d="DAV:" xmlns:s="http://sabredav.org/ns">
  <s:sabredav-version>4.3.1</s:sabredav-version>
  <s:exception>TypeError</s:exception>
  <s:message>fclose(): supplied resource is not a valid stream resource</s:message>
</d:error>

…warning

In the `$this->asset->save()` call, the stream can get closed, which leads to a TypeError when trying to close the stream. The extra `is_resource` check prevents this.

…rent background turns out black instead of white

…se-insensitive

…esting a thumbnail not deferred we need to ensure it exists

on certain database names, dropping the application log tables fails because the database name is unquoted

…n Field-Collection

…1735) * Setup Content Security Policy header based on new handler. * Content Security Handler - Whitelisting Urls (Modified)

…mcore#11817) * optimize tables with full text indexes periodically * optimize tables with full text indexes periodically

* add fillename postfix and prefix options * add filename postfix and prefix to lowqualtity command * introduce filenameRegex option * fix filenameRegex conditionVariable * empty commit * Apply suggestions from code review * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: Bernhard Rusch <brusch@users.noreply.github.com>

…ication store and Fieldcollections

* [Improvement] Copy the icon path by clicking the icon * Update bundles/AdminBundle/Resources/views/Admin/Misc/iconList.html.twig * Update iconList.html.twig * Update bundles/AdminBundle/Resources/views/Admin/Misc/iconList.html.twig Co-authored-by: Bernhard Rusch <brusch@users.noreply.github.com>

…esult (pimcore#11825) * Fix: KeyGroupRelation::getById returns wrong result * Fix also CollectionGroupRelation, use LEFT JOIN, throw/catch NotFoundException

The header of a custom-report when exporting to CSV was repeating every 5000 entries. Fixed this to only print the header once.

…mcore#11763) * Image Optimization using the new package - spatie/image-optimizer * Fix - Image Optimization using spatie/image-optimizer * Fix - Image Optimization using spatie/image-optimizer * Fix - spatie/image-optimizer * Update lib/Image/Optimizer/AbstractCommandOptimizer.php Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de> * Updated deprecation message - spatie/image-optimizer * Spatie image optimizer changes * Update doc/Development_Documentation/23_Installation_and_Upgrade/09_Upgrade_Notes/README.md Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de> * Fixed upgrade notes Co-authored-by: Jacob Dreesen <j.dreesen@neusta.de> Co-authored-by: Bernhard Rusch <bernhard.rusch@elements.at>

…e to protected (pimcore#11846) * Changed the method mode * Changed the method mode * Update Areablock.php Co-authored-by: Bernhard Rusch <brusch@users.noreply.github.com>

# Conflicts: # bundles/InstallBundle/Resources/install.sql

…re#11812

…s deprecate (pimcore#12458) * [PHP 8.1] fix Passing null to parameter #1 ($string) of type string is deprecate https://github.com/coreshop/CoreShop/runs/6981738951?check_suite_focus=true#step:17:93 * Update Staticroute.php * Update Staticroute.php * Update Staticroute.php * Update models/Staticroute.php Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de> Co-authored-by: Bernhard Rusch <brusch@users.noreply.github.com> Co-authored-by: Sebastian Blank <sebastian.bl@gmx.de>

… Passing null to parameter #1 ($string) of type string is deprecated" when calling it with null

… Passing null to parameter #1 ($string) of type string is deprecated" when calling it with null (pimcore#12839)

Example error message: Warning: Undefined array key "localizedfields" Es ist eine Ausnahme aufgetreten - der Vorgang konnte nicht durchgeführt werden. Bitte laden Sie die Adminoberfläche neu und versuchen Sie es danach erneut.Timestamp: Wed Nov 09 2022 16:06:23 GMT+0100 (Mitteleuropäische Normalzeit) Status: 500 | Internal Server Error URL: /admin/object-helper/grid-get-column-config Message: Warning: Undefined array key "localizedfields" Trace: in /var/www/html/vendor/pimcore/pimcore/models/DataObject/Service.php:1263 #0 /var/www/html/vendor/pimcore/pimcore/bundles/AdminBundle/Controller/Admin/DataObject/DataObjectHelperController.php(257): Pimcore\Model\DataObject\Service::getCustomGridFieldDefinitions('subscription', 49356) #1 /var/www/html/vendor/pimcore/pimcore/bundles/AdminBundle/Controller/Admin/DataObject/DataObjectHelperController.php(225): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectHelperController->doGetGridColumnConfig(Object(Symfony\Component\HttpFoundation\Request), Object(Pimcore\Config)) #2 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(153): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectHelperController->gridGetColumnConfigAction(Object(Symfony\Component\HttpFoundation\Request), Object(Pimcore\Config)) #3 /var/www/html/vendor/symfony/http-kernel/HttpKernel.php(75): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) pimcore#4 /var/www/html/vendor/symfony/http-kernel/Kernel.php(202): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) pimcore#5 /var/www/html/public/index.php(40): Symfony\Component\HttpKernel\Kernel->handle(Object(Symfony\Component\HttpFoundation\Request)) pimcore#6 {main}

…ype string is deprecated"

…ype string is deprecated" (pimcore#13828)

…f type resource, null given Folder Preview $tileThumb->getStream can return null

* Update Video.php Pimcore\Model\Asset\Video::getThumbnailConfig(): Argument #1 ($config) must be of type Pimcore\Model\Asset\Video\Thumbnail\Config|string, null given, called in /var/www/html/vendor/pimcore/pimcore/models/Document/Editable/Video.php on line 492 File: /var/www/html/vendor/pimcore/pimcore/models/Asset/Video.php Line: 73 * Update Video.php strpos(): Argument #1 ($haystack) must be of type string, int given File: /var/www/html/vendor/pimcore/pimcore/models/Document/Editable/Video.php Line: 938 some values arent strings

…when uploading video (pimcore#15621) * Fix: Ceil():Argument #1 ($num) must be of type int|float, null given when uploading video * Fix wrong php doc. * move ceil to getDurationString() * Remove unnecessary int cast * Make getDurationString non static

…of type int|float, string given

…$string1) of type string is deprecated" when cpath is NULL

* Fallback to url if text is disabled Fix `htmlspecialchars(): Argument #1 ($string) must be of type string, null given` * Update models/Document/Editable/Link.php Readable code Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com> --------- Co-authored-by: Divesh Pahuja <divesh.pahuja@pimcore.com>

…core#15861) * set cpath when using AbstractElement::setProperty() * prevent error "E_DEPRECATED: strcmp(): Passing null to parameter #1 ($string1) of type string is deprecated" when cpath is NULL * fill cpath based on owner element if not set

Automated PR from CE repository

…iven

…aVersionTimestamp) must be of type int, null given (pimcore#18057)

…ull given (pimcore#18535)

Can not filter checkbox values in Grid. Fatal Error File - vendor/doctrine/dbal/src/Connection.php Line - 568 Trace - Doctrine\DBAL\Connection::quote(): Argument #1 ($value) must be of type string, int given, called in vendor/pimcore/pimcore/models/DataObject/ClassDefinition/Data/Checkbox.php on line 174 Trace - #0 vendor/pimcore/pimcore/models/DataObject/ClassDefinition/Data/Checkbox.php(174): Doctrine\DBAL\Connection->quote() #1 vendor/pimcore/pimcore/models/DataObject/ClassDefinition/Data/Checkbox.php(158): Pimcore\Model\DataObject\ClassDefinition\Data\Checkbox->getFilterConditionExt() #2 vendor/pimcore/admin-ui-classic-bundle/src/Helper/GridHelperService.php(366): Pimcore\Model\DataObject\ClassDefinition\Data\Checkbox->getFilterCondition() #3 vendor/pimcore/admin-ui-classic-bundle/src/Helper/GridHelperService.php(667): Pimcore\Bundle\AdminBundle\Helper\GridHelperService->getFilterCondition() pimcore#4 vendor/pimcore/admin-ui-classic-bundle/src/Controller/Admin/DataObject/DataObjectActionsTrait.php(102): Pimcore\Bundle\AdminBundle\Helper\GridHelperService->prepareListingForGrid() pimcore#5 vendor/pimcore/admin-ui-classic-bundle/src/Controller/Admin/DataObject/DataObjectController.php(1693): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectController->gridProxy() pimcore#6 vendor/symfony/http-kernel/HttpKernel.php(181): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectController->gridProxyAction() pimcore#7 vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw() pimcore#8 vendor/symfony/http-kernel/Kernel.php(197): Symfony\Component\HttpKernel\HttpKernel->handle() pimcore#9 vendor/symfony/runtime/Runner/Symfony/HttpKernelRunner.php(35): Symfony\Component\HttpKernel\Kernel->handle() pimcore#10 vendor/autoload_runtime.php(29): Symfony\Component\Runtime\Runner\Symfony\HttpKernelRunner->run() pimcore#11 public/index.php(19): require_once('...') pimcore#12 {main}

…ore#18321) Pimcore\Translation\Translator::trans(): Argument #1 ($id) must be of type string, null given Fixed by adding a condition to check whether abbreviation is null and using the untranslated ID instead.

…reationDate) must be of type string, null given (pimcore#18678) * Update creationDate assignment with fallback * Check creation date when setting creation date

mcop1 and others added 30 commits March 31, 2022 10:02

[Bug]: In the Classification store view the X button deletes without …

cdf74c2

…warning

Prevent error when updating an existing asset via WebDav

5cc6c8f

In the `$this->asset->save()` call, the stream can get closed, which leads to a TypeError when trying to close the stream. The extra `is_resource` check prevents this.

workaround for edge-cases (web-thumbnail-->.ai to jpeg) where transpa…

76add48

…rent background turns out black instead of white

Apply php-cs-fixer changes

c96ff7c

[Asset] Imagick::isVectorGraphic(): file-extension check should be ca…

a3c2992

…se-insensitive

Merge remote-tracking branch 'origin/10.3' into 10.x

d2dcaf5

[Asset] Thumbnail cache: only relevant when $deferred=true, when requ…

5ac4a71

…esting a thumbnail not deferred we need to ensure it exists

Create LogArchiveTask.php (pimcore#11814)

fac711e

on certain database names, dropping the application log tables fails because the database name is unquoted

Create LogArchiveTask.php (pimcore#11814)

f03d39c

on certain database names, dropping the application log tables fails because the database name is unquoted

[Bug]: Localized CalculatedValue field is not aware of its position i…

01a6e1d

…n Field-Collection

Apply php-cs-fixer changes

555fa23

CKEditor upgrade to 4.18.0

c2a57fc

Merge remote-tracking branch 'origin/10.3' into 10.x

87972b4

Added error message for cstore

3ed91cf

Setup Content Security Policy header based on new handler. (pimcore#1…

c931998

…1735) * Setup Content Security Policy header based on new handler. * Content Security Handler - Whitelisting Urls (Modified)

[Maintenance] Optimize tables with full text indexes periodically (pi…

94868b5

…mcore#11817) * optimize tables with full text indexes periodically * optimize tables with full text indexes periodically

Apply php-cs-fixer changes

5598957

Changed error message

e366ade

Merge PR pimcore#11813 - [Bug]: Added warning on X button for Classif…

570d6ff

…ication store and Fieldcollections

Fix: Set doc types permission to users

7462c60

Apply php-cs-fixer changes

f77ba96

Fix KeyGroupRelation/CollectionGroupRelation: getById returns wrong r…

12757b3

…esult (pimcore#11825) * Fix: KeyGroupRelation::getById returns wrong result * Fix also CollectionGroupRelation, use LEFT JOIN, throw/catch NotFoundException

reapeating Headers of Custom-Report export

d79f617

The header of a custom-report when exporting to CSV was repeating every 5000 entries. Fixed this to only print the header once.

Apply php-cs-fixer changes

2ac3c45

Fix PHP-FPM status/ping routes in nginx config examples

9dcfe24

Changed the mode of the method renderDialogBoxEditables() from privat…

90b8518

…e to protected (pimcore#11846) * Changed the method mode * Changed the method mode * Update Areablock.php Co-authored-by: Bernhard Rusch <brusch@users.noreply.github.com>

Merge remote-tracking branch 'origin/10.3' into 10.x

265d95f

# Conflicts: # bundles/InstallBundle/Resources/install.sql

brusch and others added 2 commits April 5, 2022 15:41

[Icon Library] Changed cursor in icons to copy - follow-up to pimco…

9ecae6b

…re#11812

Merge branch 'pimcore:10.x' into bugfix/error-during-webdav-asset-update

bd9e331

BlackbitDevs closed this Apr 5, 2022

BlackbitDevs pushed a commit that referenced this pull request Aug 8, 2022

Input::getVersionPreview() prevent "E_DEPRECATED: htmlspecialchars():…

d8e7571

… Passing null to parameter #1 ($string) of type string is deprecated" when calling it with null

BlackbitDevs pushed a commit that referenced this pull request Aug 23, 2022

Input::getVersionPreview() prevent "E_DEPRECATED: htmlspecialchars():…

026a43a

… Passing null to parameter #1 ($string) of type string is deprecated" when calling it with null (pimcore#12839)

BlackbitDevs pushed a commit that referenced this pull request Dec 19, 2022

prevent deprecated error "Passing null to parameter #1 ($string) of t…

3621ecc

…ype string is deprecated"

BlackbitDevs pushed a commit that referenced this pull request Dec 20, 2022

prevent deprecated error "Passing null to parameter #1 ($string) of t…

ed1eafe

…ype string is deprecated" (pimcore#13828)

BlackbitDevs pushed a commit that referenced this pull request Jan 4, 2023

Folder Preview stream_get_contents(): Argument #1 ($stream) must be o…

179a556

…f type resource, null given Folder Preview $tileThumb->getStream can return null

BlackbitDevs pushed a commit that referenced this pull request Aug 30, 2023

QuantityValue: NumberFormatter::format(): Argument #1 ($num) must be …

6e60100

…of type int|float, string given

BlackbitDevs pushed a commit that referenced this pull request Aug 30, 2023

prevent error "E_DEPRECATED: strcmp(): Passing null to parameter #1 (…

9d5ef5b

…$string1) of type string is deprecated" when cpath is NULL

BlackbitDevs pushed a commit that referenced this pull request Jan 19, 2024

Merge pull request #1 from pimcore/11.x-from-CE

14eb380

Automated PR from CE repository

BlackbitDevs pushed a commit that referenced this pull request Aug 12, 2024

Fix: Task::setDate(): Argument #1 ($date) must be of type int, null g…

cc6cf62

…iven

BlackbitDevs pushed a commit that referenced this pull request May 26, 2025

Fix: AbstractElement::__setDataVersionTimestamp(): Argument #1 ($_dat…

355543e

…aVersionTimestamp) must be of type int, null given (pimcore#18057)

kingjia90 pushed a commit that referenced this pull request Aug 8, 2025

bug fix for strlen(): Argument #1 ($string) must be of type string, n…

d0f2a5d

…ull given (pimcore#18535)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent error when updating an existing asset via WebDav#1

Prevent error when updating an existing asset via WebDav#1
BlackbitDevs wants to merge 32 commits into
10.xfrom
bugfix/error-during-webdav-asset-update

BlackbitDevs commented Apr 4, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

BlackbitDevs commented Apr 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

BlackbitDevs commented Apr 4, 2022 •

edited

Loading