Support displaying field collections in the grid view.#2
Closed
BlackbitDevs wants to merge 6 commits into
Closed
Conversation
Review Checklist
|
BlackbitDevs
commented
Jan 9, 2024
| foreach ($fd->getFieldDefinitions() as $localizedFieldDefinition) { | ||
| $title = $localizedFieldDefinition->title ?? $localizedFieldDefinition->getName(); | ||
| $html .= '<tr><td>' . $title . ':</td><td>'; | ||
| $html .= $item->get($localizedFieldDefinition->getName()); |
Owner
Author
There was a problem hiding this comment.
Better use
$getter = 'get'.ucfirst($localizedFieldDefinition->getName());
$localizedFieldDefinition->getDataForGrid($item->$getter());?
BlackbitDevs
commented
Jan 9, 2024
| } else { | ||
| $title = $fd->title ?? $fd->getName(); | ||
| $html .= '<tr><td>' . $title . ':</td><td>'; | ||
| $html .= $fd->getVersionPreview($item->getObjectVar($fd->getName()), $object, $params); |
Owner
Author
There was a problem hiding this comment.
Why getVersionPreview() and not getDataForGrid()?
Owner
Author
|
I updated pimcore#16444 so this PR can be closed. |
BlackbitDevs
pushed a commit
that referenced
this pull request
Jan 19, 2024
BlackbitDevs
pushed a commit
that referenced
this pull request
Jan 19, 2024
…f type ?Concrete, Localizedfield given (pimcore#15763) * Fix: Wrong return type in RgbaColor::getDataForEditmode() * Use getDataForEditmode
kingjia90
pushed a commit
that referenced
this pull request
Aug 29, 2025
Can not filter checkbox values in Grid. Fatal Error File - vendor/doctrine/dbal/src/Connection.php Line - 568 Trace - Doctrine\DBAL\Connection::quote(): Argument #1 ($value) must be of type string, int given, called in vendor/pimcore/pimcore/models/DataObject/ClassDefinition/Data/Checkbox.php on line 174 Trace - #0 vendor/pimcore/pimcore/models/DataObject/ClassDefinition/Data/Checkbox.php(174): Doctrine\DBAL\Connection->quote() #1 vendor/pimcore/pimcore/models/DataObject/ClassDefinition/Data/Checkbox.php(158): Pimcore\Model\DataObject\ClassDefinition\Data\Checkbox->getFilterConditionExt() #2 vendor/pimcore/admin-ui-classic-bundle/src/Helper/GridHelperService.php(366): Pimcore\Model\DataObject\ClassDefinition\Data\Checkbox->getFilterCondition() #3 vendor/pimcore/admin-ui-classic-bundle/src/Helper/GridHelperService.php(667): Pimcore\Bundle\AdminBundle\Helper\GridHelperService->getFilterCondition() pimcore#4 vendor/pimcore/admin-ui-classic-bundle/src/Controller/Admin/DataObject/DataObjectActionsTrait.php(102): Pimcore\Bundle\AdminBundle\Helper\GridHelperService->prepareListingForGrid() pimcore#5 vendor/pimcore/admin-ui-classic-bundle/src/Controller/Admin/DataObject/DataObjectController.php(1693): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectController->gridProxy() pimcore#6 vendor/symfony/http-kernel/HttpKernel.php(181): Pimcore\Bundle\AdminBundle\Controller\Admin\DataObject\DataObjectController->gridProxyAction() pimcore#7 vendor/symfony/http-kernel/HttpKernel.php(76): Symfony\Component\HttpKernel\HttpKernel->handleRaw() pimcore#8 vendor/symfony/http-kernel/Kernel.php(197): Symfony\Component\HttpKernel\HttpKernel->handle() pimcore#9 vendor/symfony/runtime/Runner/Symfony/HttpKernelRunner.php(35): Symfony\Component\HttpKernel\Kernel->handle() pimcore#10 vendor/autoload_runtime.php(29): Symfony\Component\Runtime\Runner\Symfony\HttpKernelRunner->run() pimcore#11 public/index.php(19): require_once('...') pimcore#12 {main}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.