Skip to content

jhan_JaC_Redux_JAC_5.7_p1

Paul Leopardi edited this page Oct 8, 2024 · 4 revisions

Modified files in src/util

i)cable_pack_mod.F90

a) removed using frac_surft as not needed. There is no packing at the toplevel. This might change if LFRic gets rid of (row_length,rows) dimensionality further down butthis is what I am waiting to hear back from Richard about. No one seems to quite understand what their intentions. The only way I can imagine it is if they are intending to pack 1-D vectors like CABLE already does. In which case we will need to PACK at the toplevel. Point is though that at the moment we are not. Nonetheless L_tile_pts is slightly more important than just being embedded inside another routine that is hopefully called first. I can't remember how respectfully I have treated this myself.

b) Bugfix: nnvg should be mstype

c) In HAC I was calling mstype=9 - "ICE". When this showed up as a difference I thought to add "cbl" to it as there is already a type "ICE" for JULES. Then I added soiltype as there is also going to be a ICEvegtype_cbl

ii) cable_pack_mod.F90

There is no beam fraction until cable calculates it. VIS+NIR=sw_down which goes through to cable every timestep and then it gets split up. It might be harder to try and do this at this point than just go with what we have.

Previous | Next

Clone this wiki locally