Skip to content

Firefly-1403: Fixes: #6 #7 #11 #13 #23 #24 #26 #27 #13.7 #30 #31 #33 …#1487

Merged
robyww merged 1 commit intoUI-conversionfrom
FIREFLY-1403-issues
Feb 1, 2024
Merged

Firefly-1403: Fixes: #6 #7 #11 #13 #23 #24 #26 #27 #13.7 #30 #31 #33 …#1487
robyww merged 1 commit intoUI-conversionfrom
FIREFLY-1403-issues

Conversation

@robyww
Copy link
Copy Markdown
Contributor

@robyww robyww commented Feb 1, 2024

@robyww robyww added bug UI Client side UI changes not related to any of the visualizers labels Feb 1, 2024
@robyww robyww added this to the UI-conversion milestone Feb 1, 2024
@robyww robyww requested a review from lrebull February 1, 2024 17:37
@robyww robyww self-assigned this Feb 1, 2024
@robyww robyww changed the title Firefly-1404: Fixes: #6 #7 #11 #13 #23 #24 #26 #27 #13.7 #30 #31 #33 … Firefly-1403: Fixes: #6 #7 #11 #13 #23 #24 #26 #27 #13.7 #30 #31 #33 … Feb 1, 2024
@lrebull
Copy link
Copy Markdown
Contributor

lrebull commented Feb 1, 2024

  • Number 13 appears twice in your list.
  • Number 12 in my page you said you couldn't reproduce, so I added a screenshot to explain.
  • Number 13.7 is only partially fixed - the "e.g." under the time selection boxes in the temporal search are still italics.
  • Number 30 is partially done - the header is changed, but no help button added (it's fine if you want to reject that part of it; i just need to know that you've rejected that part of it)
  • Number 33 didn't catch all the changes. I can talk through them if you want. I made a detailed list here:
    Screen Shot 2024-02-01 at 10 37 24 AM

@lrebull
Copy link
Copy Markdown
Contributor

lrebull commented Feb 1, 2024

I can make DCE work now, but i have new bugs for you there; will add stuff to the confluence page.

@robyww
Copy link
Copy Markdown
Contributor Author

robyww commented Feb 1, 2024

@lrebull I finished 13.7 and 33

For 30 I don't think it need a help since the dialog acts more like a dropdown. Once you click is goes away.

@lrebull
Copy link
Copy Markdown
Contributor

lrebull commented Feb 1, 2024

re: 30 - i am not sure that I, personally, understand the difference between "FITS Image Pixel, and "Zero based Image pixel" but i can put that in the docs anyway so that people can find it.

agree 13.7 fixed

33 - that one tooltip still has a period at the end of it.

@robyww robyww force-pushed the FIREFLY-1403-issues branch from c3ef78a to 6f0e421 Compare February 1, 2024 23:32
@robyww
Copy link
Copy Markdown
Contributor Author

robyww commented Feb 1, 2024

ok, fixed the last of 33. I am going to merge and calling this ticket done.

@robyww robyww merged commit 2369ad3 into UI-conversion Feb 1, 2024
@robyww robyww deleted the FIREFLY-1403-issues branch April 12, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug UI Client side UI changes not related to any of the visualizers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants