version 9.40 #102
Merged
version 9.40 #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chkp-ofirs
commented
Oct 20, 2022
chkp-ofirs
commented
- Added a pre-commit code
- Formating: dot net format
- Added new logic to optimize policy based on comments
- SmartConnector : Adding the option to reuse a group name rather than creating a new one so all the data will be added to the existing name
- slicing custom-fields.field-1 in case exceeded 250 chars
sync staging to the master
1. Added a new command line switch:
'--ignore-conversion-comments', default="false",
help="The argument indicates that SmartConnector should not add conversion comments into custom-fields.field-1 [true, false]")
2. Check overflow for custom-fields.field-1 , if needed slice
Revert "SmartConnector: Override character limitation of custom-fields"
dotnet format whitespace --no-restore
format whitespace
fixes whitespace
Update .pre-commit-config.yaml
1. fixing all pre-commit issues 2. upgrade SmartMove/SmartConnector/smartconnector.py to py 3.7
pre-commit-config updates
Detect hardcoded secrets
update pre-commit
Adding the option to optimize by comments for Cisco and FirePower:
CheckPointObjects/RuleBaseOptimizer.cs
if (IsOptimizeByComments && rule1.Comments != rule2.Comments || IsOptimizeByComments && string.IsNullOrEmpty(rule1.Comments))
Logic:
1. rules can be merged if they have the same comments
2. both the source and destination columns match
3. both the source and service columns match
4. both the destination and service columns match
Enabled by a checkbox
a command line argument that default value false ( '-obc | --optimize-by-comments')
Reuse group name added command line argument that SmartConnector should use reuse the group by name instead of creating a new group. --reuse-group-name', default="false"
increased from 150 to 250, limit is 255
update to version 9.40
Update CheckPointObjects.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.