fix focus always be a penalty when install GUNMOD with INSTALL_DIFFICULT #80105
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "fix focus always be a penalty when install GUNMOD with
INSTALL_DIFFICULT"Purpose of change
In
gunmod_installation_odds, it is said thatfocus is either a penalty or bonus of at most +/-10%, but that's not how it works right now. Actually, withstd::min( std::max( get_focus(), 140 ), 60 ), focus always gives you a -10% penalty.Describe the solution
Fix it by using
std::clamp( get_focus(), 60, 140 ).Describe alternatives you've considered
Not only fix this minor issue, but also refactor
gunmod_installation_odds.Testing
TBD
Additional context