Birmingham | 26-ITP-May |Gabriel Pawuoi | Sprint 1 | Fix median function - #1398
Birmingham | 26-ITP-May |Gabriel Pawuoi | Sprint 1 | Fix median function #1398KhotKeys wants to merge 1 commit into
Conversation
LonMcGregor
left a comment
There was a problem hiding this comment.
Hi gabriel, I saw you made a lot of different PRs for this task. In Sprint 1 here, it's fine to combine them all into one. Can you do that? Thanks
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
1 similar comment
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
I thought it would be easier for the quick review if it is one after the other, now, I will have to combine all and create a single PR, right? |
|
For this task, having it all in one place is easier to review as it allows all the tests to be run at once. Yes, if you could put them together, that would be great |
I have combined, done. |
Learners, PR Template
Self checklist
Changelist