Skip to content

Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 1 | Includes - #1402

Open
KhotKeys wants to merge 3 commits into
CodeYourFuture:mainfrom
KhotKeys:includes
Open

Birmingham | 26-ITP-May | Gabriel Pawuoi | Sprint 1 | Includes#1402
KhotKeys wants to merge 3 commits into
CodeYourFuture:mainfrom
KhotKeys:includes

Conversation

@KhotKeys

@KhotKeys KhotKeys commented Aug 7, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Refactored the includes function from a traditional for index loop to a cleaner for...of loop.

  • The logic and all existing tests remain unchanged, only the iteration style was updated.

@KhotKeys KhotKeys added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 7, 2026
@LonMcGregor

Copy link
Copy Markdown

See my comment on #1398

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants