feat(reports): leftover-map incomplete items on grouping comparison graphic (v2.66.0) - #849
Conversation
…raphic (v2.66.0) Caption leftover-map incomplete item coverage on the grouping comparison leftover-map graphic from already-named leftover_map_coverage (ADR 0309). Distinct accessible name Leftover map comparison graphic incomplete items. Never invent a leftover score or a theta.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
📝 Info: Caption failures remain isolated
Each comparison caption uses its own validator. Contradictory incomplete-item data suppresses only that caption, preserving every independently valid coverage caption.
(Refers to this code)
Was this helpful? React with 👍 or 👎 to provide feedback.
| [project] | ||
| name = "lineageweave" | ||
| version = "2.65.0" | ||
| version = "2.66.0" |
There was a problem hiding this comment.
🟡 Locked package version remains stale
The project declares 2.66.0, but uv.lock still records 2.65.0. Frozen dependency workflows therefore consume stale release metadata.
Prompt for agents
Regenerate uv.lock after changing the project version in pyproject.toml, and commit the resulting lineageweave package-version update from 2.65.0 to 2.66.0. Verify the repository's frozen uv sync workflow uses a lock consistent with the declared release version.
Was this helpful? React with 👍 or 👎 to provide feedback.
| export const LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_ITEM_LABEL = | ||
| "Leftover map comparison graphic incomplete items"; |
There was a problem hiding this comment.
📝 Info: Accessible labels remain distinct
The new label differs from both existing incomplete-item labels. Every supported non-English locale maps it, preventing fallback to English.
Was this helpful? React with 👍 or 👎 to provide feedback.
| {incompleteItemCount !== null ? ( | ||
| <p | ||
| className="leftover-map-plot-incomplete-items" | ||
| role="note" | ||
| aria-label={t(LEFTOVER_MAP_PLOT_INCOMPLETE_ITEM_LABEL)} | ||
| aria-label={t( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_INCOMPLETE_ITEM_LABEL | ||
| : LEFTOVER_MAP_PLOT_INCOMPLETE_ITEM_LABEL, | ||
| )} |
There was a problem hiding this comment.
📝 Info: Report behavior stays unchanged
Report plots already rendered valid incomplete-item counts. The variant branch preserves their existing accessible label while enabling comparison plots.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Stacked next increment: leftover-map reconstruction on the grouping comparison leftover-map graphic (ADR 0310 / v2.67.0) is #850 @ Leave #849 open for independent review. Do not squash-merge. Do not self-approve. Tests on this exact head were already green (Full test suite, Frontend lint/test/build). |
|
Queue retry: leftover-map incomplete items on grouping comparison graphic (v2.66.0 / ADR 0309). Independent APPROVE required before squash-merge. Do not self-approve. Next stacked increment is reconstruction on that graphic (#850 / ADR 0310), then explained leftover share. |
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Caption persisted leftover-map incomplete-item coverage on the grouping-comparison leftover-map graphic when
leftoverMapIncompleteItemCountreturns a usable dropped count (ADR 0309 / v2.66.0). It omits independently from post/item complete-case and incomplete-post coverage. No SQL/new columns; never synthesize dropped criteria from scored-minus-used or plot statistics.Live authority
#848@4fd48d00e0473160ed05ecd5d168598ba5d688f5b83479b7063f3a3a7e880ed6869bb940bb4705084, behind0Parent convergence
#849 inherited
tests/test_compare_graphic_adr_status.pyasc5f2c1830155735e715e4ed0020afcec4f9679c7. GitHub produced exact current-parent mergea17404ba0117a360c0703678e8dbca673647c395, verified with parents#848@4fd48d00...and#849@c5f2c183...; its tree preserves ADR 0309/v2.66.0 and ADR0305–0309 amendments while keeping ADR 0304Proposed. That tree was recorded child-first asb83479b7...; branch movement was non-force only.Historical
781frontend tests/oxlint/py_compile evidence predates this exact head and is not transferred. Exact-head required/frontend/browser/a11y and PostgreSQL/k6 evidence plus independent approval remain outstanding. Any direct descendant must be reconstructed before predecessor evidence transfers.Product invariants
0remains valid when persisted counts satisfy the contract.Keep Draft until exact-head evidence and independent approval exist. No self-approval, gate bypass, force push, or destructive rebase.