feat(reports): leftover-map reconstruction on grouping comparison graphic (v2.67.0) - #850
Conversation
…phic (v2.67.0)
Caption persisted leftover-map reconstruction R̂ on the grouping comparison
leftover-map graphic from already-named leftover_map_reconstruction (ADR 0310).
Comparison copy uses leftover map comparison graphic reconstruction {label}
so it stays distinct from hyphen leftover-map reconstruction {label} and from
strip Leftover map comparison reconstruction. A missing or non-finite R̂ omits
that caption and keeps leftover-map distance and comparison graphic coverage
notes. Rank-0 origin cells still name R̂ 0.00 when that reconstruction is
finite. Do not invent R̂ from leftover-map distance or plotted coordinates.
Never invent a leftover score. Never invent a theta. No new columns.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| aria-label={tf( | ||
| variant === "comparison" | ||
| ? LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_RECONSTRUCTION | ||
| : LEFTOVER_MAP_PLOT_SEGMENT_RECONSTRUCTION, | ||
| { label: segment.reconstructionLabel }, | ||
| )} |
There was a problem hiding this comment.
📝 Info: Report labels remain unchanged
The variant branch changes only comparison accessibility copy. Report plots retain the existing template and both variants use the same validated value.
Was this helpful? React with 👍 or 👎 to provide feedback.
| export const LEFTOVER_MAP_PLOT_SEGMENT_RECONSTRUCTION = | ||
| "leftover-map reconstruction {label}"; | ||
|
|
||
| export { LEFTOVER_MAP_COMPARE_PLOT_SEGMENT_RECONSTRUCTION } from "./leftoverMapReconstruction"; |
There was a problem hiding this comment.
📝 Info: Comparison copy has one source
The layout module re-exports the reconstruction label instead of duplicating it. Formatter and component callers therefore share one constant.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Queue retry: leftover-map reconstruction on grouping comparison graphic (v2.67.0 / ADR 0310). Independent APPROVE required before squash-merge. Do not self-approve. Next stacked increment is leftover-map explained leftover share on that comparison graphic (ADR 0311 / v2.68.0). Do not caption unexplained leftover share this next increment. Issues #79 and #87 stay open. |
|
Cycle retry 2026-08-31 06:25 KST: exact head Next stacked increment (ADR 0311 / v2.68.0) captions leftover-map explained leftover share on the grouping comparison leftover-map graphic with distinct accessible name |
seonghobae
added
enhancement
ChatGPT Codex Connector
1 participant
Summary
Caption persisted leftover-map reconstruction
R̂on the grouping-comparison leftover-map graphic whenformatLeftoverMapReconstructionreturns a usable signed badge (ADR 0310 / v2.67.0). Reconstruction omits independently from distance and coverage notes. No SQL/new columns; never reconstructR̂from coordinates, distance, residual, rank, coverage, pair count, or axis count.Live authority
#849@b83479b7063f3a3a7e880ed6869bb940bb47050840a6b04c1a1fe81dbb6297aadea9158b9b644955Parent convergence
After retargeting to current #849, #850 inherited the ADR-governance regression as
3e67473419b0e663833fd82208588bc7e3457426. GitHub then generated current-parent mergef6b81588a4b216bf02ed7b60178d3a19ee938534, verified with parents#849@b83479b7...and#850@3e674734.... Its tree preserves ADR 0310/v2.67.0 while carrying ADR 0304Proposedand the regression. The same tree was recorded child-first as40a6b04c...; branch movement was non-force only.Historical
790frontend tests/oxlint/py_compile evidence predates this exact head and is not transferred. Exact-head required/frontend/browser/a11y and PostgreSQL/k6 evidence plus independent approval remain outstanding. Any direct descendant must be reconstructed before predecessor evidence transfers.Product invariants
R̂omits only the comparison-graphic reconstruction caption and preserves usable distance/coverage captions.Keep Draft until exact-head evidence and independent approval exist. No self-approval, gate bypass, force push, or destructive rebase.