-
Notifications
You must be signed in to change notification settings - Fork 0
0026 r2 and explainedvariance split their undefined cases differently
Status: accepted · Date: 2026-08-14
R2.Score and
ExplainedVariance.Score
both divide by the variance of yTrue, both take forceFinite, and both were
assumed — before this was checked against scikit-learn 1.9.0 rather than read
off its source — to handle a zero denominator the same way. They do not.
sklearn.metrics.r2_score carries an explicit n < 2 check ahead of the
division: with fewer than two samples the variance of yTrue is not just
zero, it is not a defined quantity at all, and the function returns nan
regardless of force_finite, with a warning. explained_variance_score
carries no such check. A single sample still has a variance — zero, by the
definition of variance over one point — so it reaches the same
zero-denominator branch a constant multi-sample target would, and
force_finite decides it exactly as it would for any other zero variance.
R2.cs reproduces the split with two independent knobs: forceFinite
answers the zero-variance-over-two-or-more-samples branch, and
ZeroDivision answers the fewer-than-two-samples branch, which is nan
under either setting of forceFinite and therefore is not forceFinite's
case at all. ExplainedVariance.cs takes only forceFinite, because it has
no second branch to route — routing R2's fewer-than-two-samples case through
ExplainedVariance's forceFinite would already be correct, since that
case does not exist for this metric.
| Case | R² | ExplainedVariance |
|---|---|---|
| Fewer than 2 samples |
ZeroDivision's case: nan under either forceFinite setting |
Not a separate case — one sample has zero variance by definition and falls into the row below |
| Zero variance, 2+ samples (or the 1-sample case, for ExplainedVariance) |
forceFinite's case: 1 if the numerator also vanished, 0 otherwise, or unclamped nan/-inf
|
Same |
The two R² branches must not be merged: routing the fewer-than-two-samples
case through forceFinite would return -inf where scikit-learn returns
nan. Not on every fixture that reaches it with forceFinite: false,
though — the forceFinite: false branch is perfect ? nan : -inf
(src/DataNet.Metrics/R2.cs:337-343), so a single sample predicted exactly
right already yields nan and would hide the merge. Only a single wrong
sample exposes it.
-
R2.ResolveandExplainedVariance.Resolvecarry the full per-branch reasoning at the point that implements it; the class-level<remarks>onR2andExplainedVariancepoint here instead of repeating it. - Verified by
R2Tests.Fewer_than_two_samples_is_zeroDivisions_case_and_not_forceFinites,R2Tests.Zero_variance_over_two_samples_is_forceFinites_case_and_not_zeroDivisionsandR2Tests.Explained_variance_is_one_on_a_single_wrong_sample. - A metric added later that divides by a variance-like denominator should check scikit-learn's own source for an equivalent early-exit before assuming its zero-denominator handling matches either of these two.
- 0001-target-framework
- 0002-unicode-comparison-unit
- 0003-provenance-and-licensing
- 0004-levenshtein-myers-backlog
- 0005-hamming-jellyfish-divergence
- 0006-ratcliff-autojunk
- 0007-metaphone-scope
- 0008-italian-enza-nltk-divergence
- 0009-sample-consumes-a-local-feed
- 0010-stop-word-list-provenance
- 0011-persistence-format
- 0012-per-package-versioning
- 0013-sentencepiece-parity-scope
- 0014-precompiled-normalizer
- 0015-sonar-rules-in-the-build
- 0016-metrics-package-placement
- 0017-bpe-parity-scope
- 0018-multiclass-roc-auc-parallelism-is-opt-in
- 0019-the-net-analysers-run-in-the-build-too
- 0020-normalize-is-a-projection-not-a-parameter
- 0021-multioutput-is-a-method-not-an-enum
- 0022-added-token-matching-flags
- 0023-byte-level-decode-substitutes
- 0024-weighted-median-averages-within-scikit-learns-epsilon
- 0025-quickselect-replaces-a-full-sort-for-the-median
- 0026-r2-and-explainedvariance-split-their-undefined-cases-differently
- 0027-r2-and-explainedvariance-vectorize-only-a-single-output
- 0028-log1p-is-kahans-identity-not-math-log-1-plus-x
- 0029-balanced-accuracy-adjusted-is-left-to-ieee-754-at-the-edge
- 0030-cohen-kappa-keeps-scikit-learns-expected-matrix-orientation
- 0031-nosamplecorrect-mirrors-numpys-float64-upcast
- 0032-fbeta-substitutes-tp-predicted-and-support-algebraically
- 0033-compensated-sum-is-neumaiers-variant
- 0034-dropout-is-refused-for-want-of-a-user
- 0035-a-null-pre-split-is-removed-with-invert-not-isolated
- 0036-a-member-may-ship-without-an-oracle-if-it-says-so
- 0037-the-guards-run-before-the-commit
- 0038-the-gate-confronts-an-exception-tag-with-the-page-that-documents-it
- 0039-mutual-information-returns-zero-on-an-empty-input
- 0040-a-curve-is-a-sealed-class-per-curve
- 0041-one-sample-file-per-public-class
- 0042-phonetic-encoders-refuse-a-null-word
- 0043-the-equality-table-is-sized-to-the-pattern
- 0044-compression-belongs-to-the-caller
- 0045-a-console-call-carries-its-reason-on-the-line
- 0046-check-adr-immutable-runs-in-ci-only
- 0047-one-gate-per-kernel-not-one-per-alphabet
- 0048-the-gate-depends-on-the-kernel-and-the-alphabet
- 0049-two-gates-per-kernel-tested-where-the-width-is-known
- 0050-the-sentencepiece-bpe-lineage-stays-a-bpe-model
- benchmark_latest
- decisions
- equivalence
- matplotlib
- migration
- nightly_run
- numpy
- pandas
- performance
- pytorch
- seaborn
- sklearn
- statsmodels