fix(cookies): skip Orejime init when consent popup is disabled - #6013
Open
Hashim1999164 wants to merge 1 commit into
Open
fix(cookies): skip Orejime init when consent popup is disabled#6013Hashim1999164 wants to merge 1 commit into
Hashim1999164 wants to merge 1 commit into
Conversation
Orejime requires a non-empty apps list, so initializing with apps=[] when enableCookieConsentPopup is false logged a console error. Return early instead and guard showSettings when no instance exists. Fixes DSpace#6009
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
When
enableCookieConsentPopupis false, the UI no longer initializes Orejime with an emptyappslist (which Orejime rejects and logs to the console).Instructions for Reviewers
List of changes in this PR:
BrowserOrejimeService.initialize()when the cookie consent popup is disabled, instead of callinginit()withapps: [].showSettings()so it is a no-op if Orejime was never initialized.How to test:
info.enableCookieConsentPopup: falsein config (or use the existing CI env that sets this).npm run test -- --include=src/app/core/cookies/browser-orejime.service.spec.ts --browsers=ChromeHeadless(22 tests passing locally).Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.