Refactor Yokai system and architecture detection, detect architecture cross-compilation, extend architecture detection#1987
Merged
Merged
Conversation
illwieckz
force-pushed
the
illwieckz/yokai
branch
from
df79f28 to
b8b0a34
Compare
slipher
reviewed
Jul 1, 2026
illwieckz
force-pushed
the
illwieckz/yokai
branch
from
b8b0a34 to
9d5e194
Compare
slipher
reviewed
Jul 2, 2026
illwieckz
force-pushed
the
illwieckz/yokai
branch
3 times, most recently
from
1a3972a to
c69802e
Compare
Member
|
LGTM |
illwieckz
force-pushed
the
illwieckz/yokai
branch
3 times, most recently
from
a44af97 to
dcafe3a
Compare
Member
Author
|
I had missed the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
qprocessordetection.hfrom Qt upstream and recognizeloong64.The Loongsoon architecture is one of the architectures supported by
box64, so it's likely possible to run Unvanquished on it (likeppc64elandriscv64).Unify the woridng of the code, and better code in general, also fixes some edge cases Unvanquished/Dæmon wasn't triggering.
Make possible to detect when cross-compiling from one architecture to another on the same system.
I started using Yokai in a local branch of the Saigo release scripts and I noticed a linking bug happening on FreeBSD when cross-compiling a 32-bit binutils on a 64-bit system (classic
-L/usr/lib32thing). I finally fixed that by patching binutils, but that's a proof it is useful to detect that the target architecture differs from the host target.