crunch: other way to detect if a path is a file or a directory#41
Merged
crunch: other way to detect if a path is a file or a directory#41
Conversation
readdir() doesn't support file detection on all file systems, so we use stat() as a fallback. This makes the crunch tool works with files stored over the network on NFS shares on MacOS. We also report if the current code fails to detect if a path is a file or a directory, just in case some other corner case surfaces.
Member
Author
|
This looks good enough for me and it works well. It would be possible to make the code smaller by relying on When the Filesystem implementation is complete, |
This was referenced Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
readdir()doesn't support file detection on all file systems, so we usestat()as a fallback.This makes the
crunchtool works with files stored over the network on NFS shares on MacOS.We also report if the current code fails to detect if a path is a file or a directory, just in case some other corner case surfaces.
It fixes: