[DBMON-6566] Add Set up Database Monitoring with Terraform page - #36421
Conversation
Preview links (active after the
|
2bcd06d to
cb5650d
Compare
New Markdoc page at /database_monitoring/setup_agent_terraform/ with three filter dropdowns: database, db_hosting, agent_runtime. The Postgres + RDS + AWS Fargate combination has full content; other combinations render a Coming soon stub that links to the per-database setup pages. The page links to Terraform examples in DataDog/dd-database-monitoring-example, which use the path scheme <database>/<hosting>/<agent-runtime>/. As examples land there, the matching combinations are filled out on this page. Adds supporting option IDs, traits, and option groups in customization_config so the dropdowns render with the right labels. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Updates the page to match what dd-database-monitoring-example actually ships now that PR #8 has landed there. - Path links updated from postgres/rds/* to terraform/postgres/rds/*, reflecting the new top-level terraform/ tree in the example repo. - Renames option ID aws_fargate -> ecs_fargate (and adds the matching "ECS Fargate" label in options/general.yaml). The previous name was ambiguous since EKS Fargate is also AWS Fargate; the slug already said ecs-fargate, so the option ID now matches. - Adds a full Postgres + Amazon EKS branch (architecture, prereqs for BYO and greenfield modes, apply, required inputs, verify, and troubleshooting), parallel to the ECS Fargate branch. Both modes are supported by the new terraform/postgres/rds/amazon-eks/ example. - Both runtime branches now render for db_hosting in {rds, aurora, self_hosted}, not just rds. The AWS-side Terraform module is hosting-agnostic on the database side -- Aurora customers point rds_endpoint at the cluster writer endpoint, self-hosted-on-EC2 customers point at the EC2 instance. A "Hosting note" block at the top of each runtime section spells this out so customers don't have to infer it from variable names. Cloud SQL, AlloyDB, and Azure still fall through to "Coming soon" -- those need cloud-native examples. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Public-repo PR #8 renamed terraform/postgres/rds/ -> terraform/postgres/aws/ because one Terraform module covers RDS, Aurora, and self-hosted-on-EC2 (everything reachable inside an AWS VPC by SG). Update all path references on this page to match, and adjust the path-scheme in the overview to read as <database>/<cloud>/<agent-runtime>/. The docs filter values for db_hosting (rds, aurora, self_hosted) are unchanged -- they remain the customer-facing dropdown -- but all three filter values now link to the same terraform/postgres/aws/<runtime>/ directory. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The public repo (PR #8) renamed the RDS-flavored variable names to db_endpoint / db_security_group_id / db_port. Update this page to match: variable mentions in the Hosting note, the Apply blocks, and the Required inputs tables for both ECS Fargate and Amazon EKS branches. Also rewrites the "Hosting note" sections in both branches. They no longer open with "uses RDS-flavored variable names" since the names are no longer RDS-flavored. The new framing reads as a direct mapping: Point db_endpoint and db_security_group_id at: - RDS: ... - Aurora: ... - self-hosted: ... The inputs tables likewise spell out the RDS row explicitly so all three hostings get parallel treatment. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Backs the new terraform/postgres/aws/ec2/ example in DataDog/dd-database-monitoring-example. Mirrors the structure of the existing ECS Fargate and Amazon EKS sections (Hosting note, Architecture, Prerequisites, Apply, Required inputs, Verify, Troubleshooting). Adjusts the "Coming soon" guard to also exclude the EC2 combination.
The page now ships with content for every combination the dropdowns can produce, so the conditional Coming soon block is no longer reachable. Prunes mysql/sql_server, cloud_sql/alloydb/azure, and ecs_ec2 from the option groups (and the corresponding option labels + trait notes), leaving only the combinations dd-database-monitoring-example actually backs today: Postgres on RDS/Aurora/self-hosted, Agent on ECS Fargate / Amazon EKS / Amazon EC2.
Converts the Terraform setup page from Markdoc/cdocs dropdowns to standard Hugo tabs shortcode, per feedback to hold off on cdocs pilot for now. Reverts customization_config changes (option_groups, options, traits) added for cdocs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Adds a landing _index.md for /database_monitoring/setup_agent_terraform/ and moves the Postgres content to a postgres.md sub-page, following the structure Jeff suggested: top-level section per database, with tabs per agent runtime within each DB page. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
5b6a76a to
288c385
Compare
|
|
||
| Select your database to get started: | ||
|
|
||
| - [Postgres][2] |
There was a problem hiding this comment.
more DBs to be added soon
jeff-morgan-dd
left a comment
There was a problem hiding this comment.
Thanks for this PR, Sangeeta! Mostly some style guide-type fixes throughout, please also see what looks like merge conflict artifacts in traits/general.yaml.
|
|
||
| Select your database to get started: | ||
|
|
||
| - [Postgres][2] |
There was a problem hiding this comment.
This would be nice with tiles and logos by DBMS, in a similar format to pages like https://docs.datadoghq.com/database_monitoring/setup_postgres/
| - id: secrets_source | ||
| label: Secrets source | ||
| type: text | ||
| <<<<<<< HEAD |
There was a problem hiding this comment.
This and below looks like some merge conflict artifacts, please resolve - thanks!
jeff-morgan-dd
left a comment
There was a problem hiding this comment.
Thanks for this PR, Sangeeta! Mostly some style guide-type fixes throughout, please also see what looks like merge conflict artifacts in traits/general.yaml.
3e4442f to
68bfe02
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Rename index title: "Provision the Datadog Agent with Terraform" - Rename postgres title: "Provision the Datadog Agent for Postgres with Terraform" - Add main.en.yaml entry so the section appears in the left nav after ClickHouse Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jeff-morgan-dd
left a comment
There was a problem hiding this comment.
Please also address reference links for shortcodes that we discussed in Slack - thank you!
Co-authored-by: jeff-morgan-dd <jeff.morgan@datadoghq.com>
Co-authored-by: jeff-morgan-dd <jeff.morgan@datadoghq.com>
Co-authored-by: jeff-morgan-dd <jeff.morgan@datadoghq.com>
Co-authored-by: jeff-morgan-dd <jeff.morgan@datadoghq.com>
Co-authored-by: jeff-morgan-dd <jeff.morgan@datadoghq.com>
- Move link reference definitions inside each tab shortcode so Hugo resolves them correctly (references outside shortcodes don't resolve within tab scope) - Update page title per reviewer suggestion to be more specific for search and AI agents: distinguish DBM setup from generic Postgres integration Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jeff-morgan-dd
left a comment
There was a problem hiding this comment.
Looks good! Thank you for working through all the changes @sangeetashivaji!
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
Added to the queue but the mergequeue is not enabled for now.
sangeeta.shivajirao@datadoghq.com unqueued this merge request |
|
/merge -c |
|
View all feedbacks in Devflow UI.
|
What does this PR do? What is the motivation?
Fixes DBMON-6566
Adds a new Markdoc page at
/database_monitoring/setup_agent_terraform/with three filter dropdowns (Database, Database hosting, Agent runtime). Three combinations are populated end-to-end (architecture, prerequisites, apply, inputs, verify, troubleshooting), all for Postgres on AWS:terraform/postgres/aws/ecs-fargate/terraform/postgres/aws/amazon-eks/terraform/postgres/aws/ec2/The dropdowns only expose the values the page currently has content for: Postgres as the database; RDS / Aurora / self-hosted as the hosting; ECS Fargate / Amazon EKS / Amazon EC2 as the Agent runtime. There is no longer a "Coming soon" stub — every combination the dropdowns produce renders real content. As more databases / clouds / runtimes land in
DataDog/dd-database-monitoring-example, this page (and its option groups) is extended.Also adds the supporting option IDs, traits, and option groups in
customization_config/so the dropdowns render with the right labels.Merge instructions
Merge readiness: