Skip to content

Add MySQL Terraform agent provisioning docs - #37071

Merged
sangeetashivaji merged 7 commits into
masterfrom
sangeeta.shivajirao/dbm-mysql-terraform-docs
Jun 12, 2026
Merged

Add MySQL Terraform agent provisioning docs#37071
sangeetashivaji merged 7 commits into
masterfrom
sangeeta.shivajirao/dbm-mysql-terraform-docs

Conversation

@sangeetashivaji

@sangeetashivaji sangeetashivaji commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What does this PR do? What is the motivation?

Adds a new MySQL page at /database_monitoring/setup_agent_terraform/mysql/ and adds a MySQL card to the Terraform landing page partial.

The page mirrors the structure of the existing Postgres page (PR #36421) and covers all three AWS agent runtimes using the Terraform examples from DataDog/dd-database-monitoring-example:

Agent runtime Terraform path
ECS Fargate terraform/mysql/aws/ecs-fargate/
Amazon EKS (EC2 nodes) terraform/mysql/aws/amazon-eks/
Amazon EC2 terraform/mysql/aws/ec2/

MySQL-specific differences from the Postgres page: port 3306, performance_schema prerequisites instead of pg_stat_statements, no database_name input, added optional db_port input, verify/troubleshoot steps adapted for MySQL errors.

Merge instructions

Merge readiness:

  • Ready for merge

AI assistance

Initial draft written with Claude Code.

Additional notes

@sangeetashivaji @claude
Add MySQL Terraform agent provisioning docs
affa6d0 
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sangeetashivaji
sangeetashivaji requested review from a team as code owners May 28, 2026 18:11
@github-actions github-actions Bot added the Architecture Everything related to the Doc backend label May 28, 2026
@github-actions

github-actions Bot commented May 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Preview links (active after the build_preview check completes)

New or renamed files

Modified Files

sangeetashivaji and others added 3 commits May 28, 2026 14:53
@sangeetashivaji @claude
getting_started/dbm: update guide for orders app example
1cc4222 
Replace pgbench/sysbench references with the new Go orders app:
- Describe 3-container setup (db, agent, orders app) with signals table
- Add MySQL support (make mysql) and DD_SITE note for non-US1 users
- Call out the orders.status full-table-scan as the built-in slow query
- Change explain plan step from Index Scan to Seq Scan with fix shown
- Add APM ↔ DBM correlation section
- Note mysql.queries metric for MySQL dashboard users

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sangeetashivaji
Revert "getting_started/dbm: update guide for orders app example"
96948a4 
This reverts commit 1cc4222.
@OliviaShoup
Merge branch 'master' into sangeeta.shivajirao/dbm-mysql-terraform-docs
7420ad9
@OliviaShoup OliviaShoup added the editorial review Waiting on a more in-depth review label May 28, 2026
@OliviaShoup

OliviaShoup commented May 28, 2026

Copy link
Copy Markdown
Contributor

hey, thanks for the PR! i've made an editorial review card so someone on the docs team can take a look: https://datadoghq.atlassian.net/browse/DOCS-14548

@jeff-morgan-dd jeff-morgan-dd self-assigned this Jun 1, 2026
jeff-morgan-dd
jeff-morgan-dd requested changes Jun 8, 2026
View reviewed changes

@jeff-morgan-dd jeff-morgan-dd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sangeeta, thanks for the PR! Please see my note about pricing info that we'll need to remove (and also from the Postgres counterpart).

Thank you!

Comment thread content/en/database_monitoring/setup_agent_terraform/mysql.md Outdated

- **AWS credentials** with permission to create EKS clusters, IAM roles + policy attachments, EKS managed node groups, and security-group rules.
- **At least two private subnets in different AZs** in the database's VPC, with NAT egress so the control plane and worker nodes can reach Datadog and ECR.
- **Awareness of ongoing cost** — provisioning a new EKS cluster adds approximately $0.10/hr for the control plane plus the EC2 node hourly rate, billed continuously while the cluster exists. See the [example README][7] for the full breakdown.

@jeff-morgan-dd jeff-morgan-dd Jun 8, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a strict requirement against including explicit pricing information in docs (see this page for more info), so we'll need to remove the specific rate amount. We also can't link to the README table with specific cost breakdowns.

(I see that i must have missed the cost mentions in the Postgres doc also - please remove the references there as well.)

I recommend removing the pricing info from the README altogether. If that becomes out of date, it opens us up to a significant pricing/billing liability risk.

It's OK to refer to cost in general terms (i.e. it's fine to say that a new cluster will increase costs).

@sangeetashivaji sangeetashivaji Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the message in a more general sense!

@sangeetashivaji @claude
Remove specific pricing info from EKS greenfield cost warnings
79da32d 
Docs policy prohibits explicit pricing amounts and links to cost
breakdowns. Replace the $0.10/hr rate and README breakdown links with
general language that still warns about ongoing AWS charges.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jeff-morgan-dd
jeff-morgan-dd approved these changes Jun 12, 2026
View reviewed changes

@jeff-morgan-dd jeff-morgan-dd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good! Thanks for the updates.

@sangeetashivaji

sangeetashivaji commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-06-12 13:49:49 UTC ℹ️ Start processing command /merge

2026-06-12 13:49:55 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2026-06-12 14:39:18 UTC ℹ️ MergeQueue: queue is disabled

Added to the queue but the mergequeue is not enabled for now.

2026-06-12 15:25:19 UTC ℹ️ MergeQueue: This merge request was already merged

This pull request was merged directly.

@sangeetashivaji
sangeetashivaji merged commit 27315b5 into master Jun 12, 2026
19 of 21 checks passed
@sangeetashivaji
sangeetashivaji deleted the sangeeta.shivajirao/dbm-mysql-terraform-docs branch June 12, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeff-morgan-dd jeff-morgan-dd jeff-morgan-dd approved these changes

Assignees

@jeff-morgan-dd jeff-morgan-dd

Labels

Architecture Everything related to the Doc backend editorial review Waiting on a more in-depth review mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sangeetashivaji @OliviaShoup @jeff-morgan-dd