Skip to content

Issue #391: Remove /config from release package#392

Merged
zacbaum merged 2 commits intodevelopfrom
391-update-pypi-setup
Sep 1, 2020
Merged

Issue #391: Remove /config from release package#392
zacbaum merged 2 commits intodevelopfrom
391-update-pypi-setup

Conversation

@zacbaum
Copy link
Copy Markdown
Member

@zacbaum zacbaum commented Sep 1, 2020

Description

Removes unnecessary __init__.py files and updates the setup.py script to only package required files in the releases.

Fixes #391

Type of change

  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask. We're here to help! This is
simply a reminder of what we are going to look for before merging your code.

  • I have
    installed pre-commit
    and formatted all changed files.
  • My commits' message styles matches
    our requested structure,
    e.g. Issue #<issue number>: detailed message.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

YipengHu and others added 2 commits September 1, 2020 09:20
@zacbaum zacbaum requested a review from YipengHu September 1, 2020 09:10
@zacbaum zacbaum self-assigned this Sep 1, 2020
@zacbaum zacbaum changed the base branch from main to develop September 1, 2020 09:11
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #392 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #392   +/-   ##
========================================
  Coverage    98.65%   98.65%           
========================================
  Files           29       29           
  Lines         1704     1704           
========================================
  Hits          1681     1681           
  Misses          23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d14d58...c5c3837. Read the comment docs.

@zacbaum zacbaum merged commit 5820ba2 into develop Sep 1, 2020
@zacbaum zacbaum deleted the 391-update-pypi-setup branch September 1, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update setup.py for new directory structure to package releases

4 participants