Skip to content

LIMS-1642: Fix search when clicking x on search bars#909

Merged
ndg63276 merged 1 commit intopre-release/2025-R3.2from
fix/LIMS-1642/click-x-on-search-bars
Jun 10, 2025
Merged

LIMS-1642: Fix search when clicking x on search bars#909
ndg63276 merged 1 commit intopre-release/2025-R3.2from
fix/LIMS-1642/click-x-on-search-bars

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1642

Summary:

In Chrome or Edge, when you fill in a search bar, a small x appears to clear the search bar. Synchweb should clear the search parameter when you click the x.

Changes:

To test:

  • In Chrome or Edge, go to the proposals page, search for a proposal number. Click the little x in the search bar, check all proposals are shown again

@RichB-DLS RichB-DLS self-requested a review February 28, 2025 10:36
@RichB-DLS
Copy link
Collaborator

LGTM

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R3.2 June 10, 2025 10:29
@ndg63276 ndg63276 merged commit e136916 into pre-release/2025-R3.2 Jun 10, 2025
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1642/click-x-on-search-bars branch June 10, 2025 10:31
ndg63276 added a commit that referenced this pull request Jun 24, 2025
* LIMS-1758: Fix slowness with plates with lots of subsamples (#941)

* LIMS-1758: Fix slowness with plates with lots of samples

* LIMS-1758: Remove unnecessary change

* LIMS-1758: Remove unnecessary whitespace

* LIMS-1758: Do large updates in chunks

* LIMS-1758: Use native JS

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1715: Clear sessionId from containers if a dewar transfer is requested (#939)

* LIMS-1715: Clear sessionId from containers if a dewar transfer is requested

* LIMS-1715: Clear sessionId from containers if a dewar transfer is requested

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1714: Populate Dewar.dewarRegistryId (#936)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1701: Make Xray Centring results an openable table (#935)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1642: Fix search when clicking x on search bars (#909)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1639: List most common screens at the top of the list (#928)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1777: Fix download of autoprocessing attachments on sm beamlines (#947)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants