Skip to content

LIMS-1639: List most common screens at the top of the list#928

Merged
ndg63276 merged 1 commit intopre-release/2025-R3.2from
improvement/LIMS-1639/list-common-screens-at-the-top
Jun 10, 2025
Merged

LIMS-1639: List most common screens at the top of the list#928
ndg63276 merged 1 commit intopre-release/2025-R3.2from
improvement/LIMS-1639/list-common-screens-at-the-top

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1639

Summary:

When making a new plate, you select the crystallisation screen from a dropdown list. This is currently sorted alphabetically. It would be good to put the most common 15 screens at the top of the list.

Changes:

  • Get the container count for each screen
  • Duplicate the top 15 in order, add them to the top of the list, with a separator

To test:

  • Log in to any proposal, go to a shipment, click "Add Container"
  • Switch the Container Type to a plate, eg CrystalQuickX
  • Check the Crystallisation Screen dropdown has 15 items not in alphabetical order, then the full list in alphabetical order. Check the top 15 are duplicated.
  • Go to /imaging/screen, check the screens are still in alphabetical order

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R3.2 June 10, 2025 10:29
@ndg63276 ndg63276 merged commit 5ad1586 into pre-release/2025-R3.2 Jun 10, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1639/list-common-screens-at-the-top branch June 10, 2025 10:31
ndg63276 added a commit that referenced this pull request Jun 24, 2025
* LIMS-1758: Fix slowness with plates with lots of subsamples (#941)

* LIMS-1758: Fix slowness with plates with lots of samples

* LIMS-1758: Remove unnecessary change

* LIMS-1758: Remove unnecessary whitespace

* LIMS-1758: Do large updates in chunks

* LIMS-1758: Use native JS

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1715: Clear sessionId from containers if a dewar transfer is requested (#939)

* LIMS-1715: Clear sessionId from containers if a dewar transfer is requested

* LIMS-1715: Clear sessionId from containers if a dewar transfer is requested

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1714: Populate Dewar.dewarRegistryId (#936)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1701: Make Xray Centring results an openable table (#935)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1642: Fix search when clicking x on search bars (#909)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1639: List most common screens at the top of the list (#928)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1777: Fix download of autoprocessing attachments on sm beamlines (#947)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants