LIMS-1714: Populate Dewar.dewarRegistryId#936
Merged
ndg63276 merged 1 commit intopre-release/2025-R3.2from Jun 10, 2025
Merged
Conversation
gfrn
approved these changes
Jun 9, 2025
ndg63276
added a commit
that referenced
this pull request
Jun 24, 2025
* LIMS-1758: Fix slowness with plates with lots of subsamples (#941) * LIMS-1758: Fix slowness with plates with lots of samples * LIMS-1758: Remove unnecessary change * LIMS-1758: Remove unnecessary whitespace * LIMS-1758: Do large updates in chunks * LIMS-1758: Use native JS --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1715: Clear sessionId from containers if a dewar transfer is requested (#939) * LIMS-1715: Clear sessionId from containers if a dewar transfer is requested * LIMS-1715: Clear sessionId from containers if a dewar transfer is requested --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1714: Populate Dewar.dewarRegistryId (#936) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1701: Make Xray Centring results an openable table (#935) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1642: Fix search when clicking x on search bars (#909) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1639: List most common screens at the top of the list (#928) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> * LIMS-1777: Fix download of autoprocessing attachments on sm beamlines (#947) Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk> --------- Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1714
Summary:
When we make a shipment, we should populate the Dewar.dewarRegistryId as well as facilityCode. Then on the shipment page, we currently show the dewar facility code based on the
Dewar.facilityCodefield, we should also allow joining toDewarRegistrybydewarRegistryIdand then getting thefacilityCodefrom there.Changes:
dewarRegistryIdfrom facility codedewarRegistryIdin dewars in new shipments, edited dewars, and new dewars in existing shipmentsdewarRegistryId, falling back toDewar.facilityCodeif neededTo test:
Dewar.dewarRegistryIdandDewar.facilityCodeare populated correctly.Dewar.dewarRegistryIdis updated as well asDewar.facilityCodeDewar.dewarRegistryIdandDewar.facilityCodeare populated correctly.