Skip to content

LIMS-1701: Make Xray Centring results an openable table#935

Merged
ndg63276 merged 1 commit intopre-release/2025-R3.2from
improvement/LIMS-1701/make-XRC-results-into-a-table
Jun 10, 2025
Merged

LIMS-1701: Make Xray Centring results an openable table#935
ndg63276 merged 1 commit intopre-release/2025-R3.2from
improvement/LIMS-1701/make-XRC-results-into-a-table

Conversation

@ndg63276
Copy link
Collaborator

JIRA ticket: LIMS-1701

Summary:

As the xray centring results become more in-depth, they should be displayed as an expandable table, rather than one long string of words.

Changes:

  • Mimic the Auto Processing view to make the Xray Centring results into a similar expandable section
  • Use a table view to display each result, alongside the sample identified (if any)
  • Sort results by strength by default, but that can be changed by clicking column headers

To test:

  • Find some XrayCentringResult rows with non-null blsampleids, or if none found, update some, eg
update XrayCentringResult set blsampleid=6488514 where xrayCentringResultId=1592487;
update XrayCentringResult set blsampleid=6488511 where xrayCentringResultId=1592490;
  • View the associated DataCollectionGroup (eg /dc/visit/mx23694-136/dcg/14930106), or the entire visit (eg /dc/visit/mx23694-136)
  • Click on the "Grid Scan Processing" bar, check it expands to show a table
  • Check the sample name is shown, and is a working link to the sample page
  • Check the column headers can be used to order by eg X Position (apart from Sample)
  • Check the position is given to 1 decimal place, other numbers are integers.
  • Check a grid scan that is not part of an Xray Centring, check it is unchanged and has no results bar.

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R3.2 June 10, 2025 10:29
@ndg63276 ndg63276 merged commit 33a68a8 into pre-release/2025-R3.2 Jun 10, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1701/make-XRC-results-into-a-table branch June 10, 2025 10:31
ndg63276 added a commit that referenced this pull request Jun 24, 2025
* LIMS-1758: Fix slowness with plates with lots of subsamples (#941)

* LIMS-1758: Fix slowness with plates with lots of samples

* LIMS-1758: Remove unnecessary change

* LIMS-1758: Remove unnecessary whitespace

* LIMS-1758: Do large updates in chunks

* LIMS-1758: Use native JS

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1715: Clear sessionId from containers if a dewar transfer is requested (#939)

* LIMS-1715: Clear sessionId from containers if a dewar transfer is requested

* LIMS-1715: Clear sessionId from containers if a dewar transfer is requested

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1714: Populate Dewar.dewarRegistryId (#936)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1701: Make Xray Centring results an openable table (#935)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1642: Fix search when clicking x on search bars (#909)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1639: List most common screens at the top of the list (#928)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

* LIMS-1777: Fix download of autoprocessing attachments on sm beamlines (#947)

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>

---------

Co-authored-by: Mark Williams <mark.williams@diamond.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants