Skip to content

Docs updates for E/A#98030 Document Auto-categorize new expenses workspace setting - #100099

Closed
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-auto-categorize-new-expenses
Closed

Docs updates for E/A#98030 Document Auto-categorize new expenses workspace setting#100099
MelvinBot wants to merge 1 commit into
mainfrom
melvin-docs-auto-categorize-new-expenses

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site follow-up for #98030, which added the Auto-categorize new expenses workspace setting so admins can stop Expensify from picking a category for new expenses.

The help site had no coverage of this setting: Create-expense-categories.md described automatic categorization (learned categorization, MCC default spend categories, and Workspace Merchant Rules) as though it always runs, with no way to turn it off. This PR documents the new toggle and the behavior change that follows from disabling it.

docs/articles/new-expensify/workspaces/Create-expense-categories.md

  • Added a note under How to apply categories automatically that automatic categorization is controlled by Auto-categorize new expenses, which is enabled by default.
  • Added How to turn off Auto-categorize new expenses with the navigation steps and the availability condition (categories enabled on the workspace, at least one category enabled).
  • Added What happens when Auto-categorize new expenses is turned off, covering the loss of the analyzing state on the Category field, the missing category violation appearing immediately when Members must categorize all expenses is also on, and the fact that existing expenses are untouched.
  • Added a screenshot suggestion (HTML comment, non-rendered) for the Categories Settings page.
  • Updated keywords and internalScope metadata.

docs/articles/new-expensify/workspaces/Require-tags-and-categories-for-expenses.md

  • Added Where to turn off Auto-categorize new expenses, a short pointer from the Default Spend Categories section to the full workflow, so the article doesn't imply automatic categorization is unconditional.
  • Updated keywords metadata.

All UI labels were verified against the live app before writing: the path is Workspaces > [workspace name] > Categories > More > Settings, the page header is Settings, and the settings page shows Members must categorize all expenses and Auto-categorize new expenses, both on by default.

Known accuracy gaps left out of scope

Two pre-existing inaccuracies were found while verifying the UI. They aren't caused by #98030, so they're not fixed here:

  1. Require-tags-and-categories-for-expenses.md tells readers to click Settings in the top-right of the Categories page. The Categories page now uses More > Settings. The steps cover Tags as well, and the Tags page wasn't verified, so the path wasn't changed.
  2. The same article uses the merged label Members must tag or categorize all expenses. The Categories settings page reads Members must categorize all expenses. The matching Tags label wasn't verified, so it was left alone.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/669240
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests they ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@dukenv0307, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Co-authored-by: dukenv0307 <dukenv0307@users.noreply.github.com>
Co-authored-by: Nguyen Van Duc <dukenv0307@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 2, 2026 00:48
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 2, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch because I don't have push access to your fork.

To take ownership of this branch and push updates yourself, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream melvin-docs-auto-categorize-new-expenses
git checkout -b melvin-docs-auto-categorize-new-expenses upstream/melvin-docs-auto-categorize-new-expenses
git push -u origin melvin-docs-auto-categorize-new-expenses

Then you can close this PR and open a new one from your fork.

@dukenv0307

Copy link
Copy Markdown
Contributor

original PR got reverted

@dukenv0307 dukenv0307 closed this Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants