[Payment due @truph01] Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization by dukenv0307 · Pull Request #98030 · Expensify/App

dukenv0307 · 2026-08-07T10:38:08Z

Explanation of Change

Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/669240
PROPOSAL:

Tests

Go to WS -> Category -> More -> Settings
Verify that: Auto-categorize new expenses is shown and enabled by default
Verify that we can disable/enable it
Create an expense in that WS without category
Verify that the category is missing if Auto-categorize new expenses is disabled and the category is added automatically when Auto-categorize new expenses is enabled

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2026-08-07.at.5.32.01.PM.mov

…ns disable auto-categorization

melvin-bot · 2026-08-07T10:38:13Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-08-07T10:43:26Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
...c/components/ReportActionItem/MoneyRequestView.tsx	`77.16% <100.00%> (ø)`
src/libs/API/types.ts	`100.00% <ø> (ø)`
src/libs/TransactionUtils/index.ts	`91.29% <100.00%> (+0.09%)`	⬆️
src/libs/actions/Policy/Category.ts	`49.86% <0.00%> (-0.55%)`	⬇️
...egories/DynamicWorkspaceCategoriesSettingsPage.tsx	`0.00% <0.00%> (ø)`
... and 118 files with indirect coverage changes

dukenv0307 · 2026-08-21T14:04:48Z

not overdue

melvin-bot · 2026-08-25T02:14:44Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

melvin-bot · 2026-08-26T02:26:36Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2026-08-26T02:27:24Z

@truph01 can you please prioritize this PR? Thanks 🙏

truph01 · 2026-08-26T02:34:22Z

@dukenv0307 Sure

truph01 · 2026-08-26T04:57:23Z

Bug 1:

Create new workspace
Disable all workspaces
Open WS -> Category -> More -> Settings
Observe that: Auto-categorize new expenses is shown, locked and enabled by default

In step 4, I think it should:

Auto-categorize new expenses is shown, locked and disabled.

truph01 · 2026-08-26T05:25:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained """"why"""" the code was doing something instead of only explaining """"what"""" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2026-08-26.at.12.22.00.mov

Android: mWeb Chrome

Screen.Recording.2026-08-26.at.12.22.46.mov

iOS: HybridApp

Screen.Recording.2026-08-26.at.12.15.23.mov

iOS: mWeb Safari

Screen.Recording.2026-08-26.at.12.14.25.mov

MacOS: Chrome / Safari

Screen.Recording.2026-08-26.at.12.09.02.mov

Screen.Recording.2026-08-26.at.12.23.22.mov

truph01 · 2026-08-26T05:27:19Z

Bug 2: The "Analyzing ..." is briefly shown in the category field after creating an expense where the workspace's Auto-categorize new expenses is disabled:

Screen.Recording.2026-08-26.at.12.25.27.mov

dukenv0307 · 2026-08-27T08:24:00Z

@truph01 I think you mean disable all categories.
Actually, BE will skip if the enabled cateory list is empty. Furthermore, that flag is the admin’s preference for later not “is auto-cat running right now", so I'd like to keep as it is

dukenv0307 · 2026-08-27T08:35:28Z

Bug 2: The "Analyzing ..." is briefly shown in the category field after creating an expense where the workspace's Auto-categorize new expenses is disabled:

Good catch, I fixed

heyjennahay

Product change LGTM 👍

github-actions · 2026-09-01T17:04:31Z

🚧 jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-09-01T17:08:21Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #98030.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-c293b8c-b66008c-d074b73588aaa129038dd9f45cdf331beb9176b7/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-c293b8c-b66008c-4b8f0b291eb720eaf7231b96ba8593f6c2737d1a/index.html

Web 🕸️
https://98030.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-09-02T00:35:27Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.4.66-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-09-02T00:49:13Z

Yes, help site changes are required. Draft PR: #100099

Why: this PR adds the Auto-categorize new expenses workspace setting, but the help site described automatic categorization as something that always runs, with no way to turn it off. docs/articles/new-expensify/workspaces/Create-expense-categories.md covers learned categorization, MCC default spend categories, and Workspace Merchant Rules; none of it mentions a master toggle.

What the docs PR changes

Create-expense-categories.md — added How to turn off Auto-categorize new expenses (navigation steps plus the availability condition) and What happens when Auto-categorize new expenses is turned off, plus a note under How to apply categories automatically that the setting is on by default. Updated keywords and internalScope.
Require-tags-and-categories-for-expenses.md — added Where to turn off Auto-categorize new expenses, a short pointer from Default Spend Categories to the full workflow, so that article no longer implies automatic categorization is unconditional.

UI verification: I drove the live app before writing. The path is Workspaces > [workspace name] > Categories > More > Settings, the page header is Settings, and the page shows Members must categorize all expenses and Auto-categorize new expenses, both on by default. That matches the copy added in src/languages/en.ts.

Two pre-existing doc inaccuracies I found but did not fix

Neither is caused by this PR, so I left both out of the docs PR and noted them in its body:

Require-tags-and-categories-for-expenses.md says to click Settings in the top-right of the Categories page. The Categories page now uses More > Settings. The steps also cover Tags, and I didn't verify the Tags page, so I didn't change the path.
The same article uses a merged label, Members must tag or categorize all expenses. The Categories settings page reads Members must categorize all expenses. I didn't verify the corresponding Tags label, so I left it alone.

I couldn't run cspell locally in this environment, so CI will be the first spell check on the docs PR. The wording I added uses vocabulary already present in these two files.

@dukenv0307, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

view run

mitarachim · 2026-09-02T01:15:34Z

Deploy Blocker #100108 was identified to be related to this PR.

mitarachim · 2026-09-02T01:15:44Z

Deploy Blocker #100110 was identified to be related to this PR.

mitarachim · 2026-09-02T01:26:24Z

Deploy Blocker #100111 was identified to be related to this PR.

mitarachim · 2026-09-02T02:48:10Z

Deploy Blocker issue #100115 is repro on all PRs. Could you please double check if it's not introduced by #98030

jponikarchuk · 2026-09-02T04:10:57Z

Deploy Blocker #100117 was identified to be related to this PR.

[CP Staging] Revert #98030 - Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization

[CP Staging] Revert #98030 - Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization (cherry picked from commit dc4291c) (cherry-picked to staging by roryabraham)

OSBotify · 2026-09-02T21:10:46Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.4.68-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

This reverts commit c293b8c, reversing changes made to b71529e.

OSBotify · 2026-09-02T21:48:05Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.68-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot · 2026-09-02T21:53:13Z

🤖 Payment issue created: #100225

OSBotify · 2026-09-02T22:47:50Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 9.4.69-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-09-03T18:29:53Z

🚀 Deployed to production by https://github.com/francoisl in version: 9.4.69-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

Add Auto-categorize new expenses workspace setting to let strict admi…

f9bf924

…ns disable auto-categorization

melvin-bot Bot assigned dukenv0307 Aug 7, 2026

dukenv0307 changed the title ~~Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization~~ [Hold BE] Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization Aug 7, 2026

jasperhuangg self-requested a review August 7, 2026 21:03

quinthar added #ai and removed #ai labels Aug 11, 2026

dukenv0307 changed the title ~~[Hold BE] Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization~~ Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization Aug 25, 2026

merge main

c07bed7

dukenv0307 added 2 commits August 25, 2026 09:21

update translation

40bebb1

Merge branch 'main' into fix/669240

fc89c98

dukenv0307 marked this pull request as ready for review August 26, 2026 02:26

dukenv0307 requested review from a team as code owners August 26, 2026 02:26

melvin-bot Bot requested a review from truph01 August 26, 2026 02:26

melvin-bot Bot requested review from heyjennahay and removed request for a team August 26, 2026 02:26

do not show Analyzing... when autoCategorizeNewExpenses is disabled

eabffbd

heyjennahay approved these changes Sep 1, 2026

View reviewed changes

jasperhuangg merged commit c293b8c into Expensify:main Sep 1, 2026
38 of 40 checks passed

OSBotify mentioned this pull request Sep 2, 2026

Deploy Checklist: New Expensify 2026-09-02 #100087

Closed

82 tasks

MelvinBot mentioned this pull request Sep 2, 2026

Docs updates for E/A#98030 Document Auto-categorize new expenses workspace setting #100099

Closed

40 tasks

This was referenced Sep 2, 2026

[Due for payment 2026-09-09] Workspace - Auto categorization settings is not disabled in the duplicated workspace #100108

Open

[Due for payment 2026-09-09] Expense - Expense is auto categorized after disabling auto categorisation #100110

Open

applause-bot Bot mentioned this pull request Sep 2, 2026

[Due for payment 2026-09-09] Workspace - No changelog for auto-categorisation settings is missing in #admins #100111

Open

7 tasks

applause-bot Bot mentioned this pull request Sep 2, 2026

[Due for payment 2026-09-09] Categories - Missing "Auto-categorize new expenses" for Expensifail accounts #100115

Open

7 tasks

applause-bot Bot mentioned this pull request Sep 2, 2026

[Due for payment 2026-09-09] Expense- Auto categorize new expense is not applied for concierge created expense. #100117

Open

7 tasks

MelvinBot mentioned this pull request Sep 2, 2026

Always show the Settings option in the categories More menu #100119

Closed

40 tasks

dukenv0307 mentioned this pull request Sep 2, 2026

[CP stag] Revert Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization" #100129

Closed

38 tasks

francoisl mentioned this pull request Sep 2, 2026

[CP Staging] Revert #98030 - Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization #100217

Merged

40 tasks

roryabraham added a commit that referenced this pull request Sep 2, 2026

Merge pull request #100217 from Expensify/francois-revert-98030

dc4291c

[CP Staging] Revert #98030 - Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization

x-dev90 pushed a commit to x-dev90/App that referenced this pull request Sep 2, 2026

Revert "Merge pull request Expensify#98030 from dukenv0307/fix/669240"

e2c6ab6

This reverts commit c293b8c, reversing changes made to b71529e.

melvin-bot Bot mentioned this pull request Sep 2, 2026

[Due for payment 2026-09-09] Payment issue for E/App PR#98030 #100225

Open

Uh oh!

Conversation

dukenv0307 commented Aug 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 7, 2026

Uh oh!

codecov Bot commented Aug 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dukenv0307 commented Aug 21, 2026

Uh oh!

melvin-bot Bot commented Aug 25, 2026

Uh oh!

melvin-bot Bot commented Aug 26, 2026

Uh oh!

dukenv0307 commented Aug 26, 2026

Uh oh!

truph01 commented Aug 26, 2026

Uh oh!

truph01 commented Aug 26, 2026

Uh oh!

truph01 commented Aug 26, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented Aug 26, 2026

Uh oh!

dukenv0307 commented Aug 27, 2026

Uh oh!

dukenv0307 commented Aug 27, 2026

Uh oh!

heyjennahay left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 1, 2026

Uh oh!

github-actions Bot commented Sep 1, 2026

Uh oh!

OSBotify commented Sep 2, 2026

Uh oh!

MelvinBot commented Sep 2, 2026

Uh oh!

mitarachim commented Sep 2, 2026

Uh oh!

mitarachim commented Sep 2, 2026

Uh oh!

mitarachim commented Sep 2, 2026

Uh oh!

mitarachim commented Sep 2, 2026

Uh oh!

jponikarchuk commented Sep 2, 2026

Uh oh!

OSBotify commented Sep 2, 2026

Uh oh!

OSBotify commented Sep 2, 2026

Uh oh!

melvin-bot Bot commented Sep 2, 2026

Uh oh!

OSBotify commented Sep 2, 2026

Uh oh!

OSBotify commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dukenv0307 commented Aug 7, 2026 •

edited

Loading

codecov Bot commented Aug 7, 2026 •

edited by github-actions Bot

Loading