Skip to content

Adult trade shuffle bugfixes - #1173

Merged
briaguya0 merged 4 commits into
HarbourMasters:rando-nextfrom
lilDavid:adult_trade_fixes
Aug 13, 2022
Merged

Adult trade shuffle bugfixes#1173
briaguya0 merged 4 commits into
HarbourMasters:rando-nextfrom
lilDavid:adult_trade_fixes

Conversation

@lilDavid

Copy link
Copy Markdown
Contributor

Fixes for #1151 and a few other bugs related to the shuffled adult trade sequence.
In all, this fixes the following bugs:

  • Grog and Fado can spawn at the same time
  • When hatching the Pocket Egg by using the Sun's Song in an area, your trade quest status is not properly updated
  • Setting the adult trade slot in the Save Editor doesn't set the flags properly (both setting and emptying the slot were broken lol)
  • Opening the trade item menu in the Save Editor rapidly cycles between the items you have
  • Removing a trade item cycles your trade slot when it isn't necessary

 - Having multiple items with the collapsing header open rapidly cycles trade items
 - Unchecking any item's checkbox cycles the trade item (it should only do so if it's the one you've selected)
 - Setting the adult trade slot sets the wrong items' flags
 - Emptying the adult trade slot doesn't reset all trade items' flags
@briaguya0
briaguya0 merged commit 82f69a0 into HarbourMasters:rando-next Aug 13, 2022
@briaguya0 briaguya0 mentioned this pull request Aug 13, 2022
@lilDavid
lilDavid deleted the adult_trade_fixes branch August 13, 2022 03:47
serprex pushed a commit that referenced this pull request Jul 30, 2026
Advances the libultraship pin to the port-maintenance tip
(c57da1b -> bbb565b), resolving the HD texture-pack regressions
tracked in #6837:

- Kenix3/libultraship#1135 - stop clamping HD textures to an
  undefined tile region (fixes the eye rendering)
- Kenix3/libultraship#1172 - reshape RAW block-load texture uploads
  that arrive as a single line (fixes the C-button icons)

The related #1143 buttons/Metal fix was already in the prior pin.
Also in range: #1139, #1170, #1173, #1175, #1176.

Fixes #6837.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants