[PoC] Rando "useless" checks & Potential for custom actor spawning/replacement system

[garrettjoecox]

Mostly putting this PR up to gauge interest on either topics

Useless Checks

This adds 5 checks to seemingly useless places, see images below

• Gerudo Valley Octorok Grotto
• Platform above bean patch in Kokiri Forest
• Upper Platform near lizalfos fight
• Frozen Pot in Ice Cavern Map room
• Bottom room in Jabu Jabu's belly that just has pots

There is potential for more, but wanted to see if this is even desirable first.

Custom actor spawning/replacement system

The way this is achieved is hooking into the scene load commands and either appending our own actors or replacing existing actors with our own. The code in soh/soh/z_scene_otr.cpp accomplishes this but is very much proof of concept, if this is something we want to move forward with I'm thinking it will look something like @leggettc18 's custom item system where randomizer & other mods can hook in and provide actors/replacements.

---

Again this PR is not really ready to be merged, and will probably not be unless people want it. In case they do todo list for me:

• Increase CheckTable/Spoiler table sizes
• Create and migrate to a more generalized/flexible actor add/replacement system
• Add randomizer setting for "Useless checks"
• Maybe come up with a better name than useless checks

[Alenmalen]

I love this idea very much, I had the same thoughts because there is a lot of places with potential for checks and those are some missed opportunities. Unfortunately my programming skills are basicly 0 but maybe I can provide you with some other checks that would be cool to add, if you´d like.

I especially like the idea of the check at the lizzard fights in DC because some parts of the game that are really cool are always skipped because there are no checks in that area, like this one for instance.
Also maybe putting 1 in the secret room behind the lava wall on the first flor of the lava room would be a nice idea, in Vanilla there is already a piece of heart inside, so maybe the actor can be used to make programming easier.

Anyway i support the idea of having an "Additional Checks" or something of that sort as an option for Rando, would really spice things up.
Thanks for putting in effort to making this project amazing.

[leggettc18]

So, food for thought. I'm not 100% sure, but I think these all become "useful checks" in potsanity, which is planned to happen eventually. Similarly, generalized actor replacement/addition is also probably going to happen as part of the eventual modding engine. So you may have an opportunity here for contribution to that. I'm not sure what the plans are for that exactly.