Skip to content

Migrate buildscripts to kotlin#2917

Closed
NotMyFault wants to merge 11 commits into
v6from
feature/v6/kotlin-dsl
Closed

Migrate buildscripts to kotlin#2917
NotMyFault wants to merge 11 commits into
v6from
feature/v6/kotlin-dsl

Conversation

@NotMyFault
Copy link
Copy Markdown
Collaborator

@NotMyFault NotMyFault commented Sep 20, 2020

TODO

  • Shift dependency management to buildSrc
  • Setup javadoc & sources jar task
  • Setup checkstyle task, waiting on @Sauilitired to finish up checkstyle

@Citymonstret
Copy link
Copy Markdown
Member

Go ahead with this and if we want to add the checkstyle, we can do it after this is merged.

@Citymonstret Citymonstret marked this pull request as ready for review September 23, 2020 19:23
@Citymonstret
Copy link
Copy Markdown
Member

Why the new lines after the license headers? This PR touches every file in the project for no apparent reason.

@Citymonstret Citymonstret self-requested a review September 23, 2020 19:24
@NotMyFault
Copy link
Copy Markdown
Collaborator Author

Why the new lines after the license headers? This PR touches every file in the project for no apparent reason.

I had to exchange our license plugin because the other one is not compatible with Kotlin's syntax. It appears Minecrell's adds a newline below each header even if there is no new line in the header specified.

@Proximyst Proximyst mentioned this pull request Oct 7, 2020
1 task
@NotMyFault NotMyFault closed this Oct 8, 2020
@NotMyFault NotMyFault deleted the feature/v6/kotlin-dsl branch October 9, 2020 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants