12.0. francisco ordaz t#2839 #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually, docker is used to test Linux packages once they are built.
The packaging process is done on the host system where package.py is
run.
Consequences:
* difficult to reproduce an exact same build on another host
* changing a Debian/Ubuntu target version means some upgrade steps
on the build host (mix that with the fact that the host also
could build old Odoo versions)
* Fedora rpm package is built on an Ubuntu system (which is not a
real problem but it could be)
With this commit, the package.py utility is refactored to use Docker
containers to build the Gnu/Linux packages.
closes odoo#39091
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
In form views, when the window size is too small, a "More" button
appears and it should contain the overflow buttons.
On all browsers, the "More" dropdown doesn't contain the expected
amount of buttons, so it is shifted on the second line.
Before this commit:
- The "More" dropdown doesn't contain the expected amount of
buttons, so it is shifted on the second line.
After this commit:
- The "More" dropdown contains the expected amount of buttons
and it is not shifted on the second line anymore.
OPW-2079694
closes odoo#38853
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
shop page link and popover use the same route which make a write on db to recompute coupon lines. Can lead to concurent updates if unlucky on timing. task-2070507 closes odoo#38996 X-original-commit: odoo@b5cffa8 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Due to commit odoo/odoo@f4031c6 it was not more possible to scroll in a grouped kanban. Steps to reproduce: * Go to project app * Select a project with a few numbers of task * Create as need new task to have more task than visible on the screen * Try to scroll (BUG) Note: we also fix the swipe in empty column opw-2080491 closes odoo#39103 Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
The XML file homepage view record is not supposed to be deleted as it is used to bootstrap newly created website. If that view is deleted, everything's fine. But if that view's page is not found (m2o link broken somehow), then the code would crash. This would only appear if the user is playing in the backend in technical but it seems to happen more than it should. This commit will prevent the code to crash in such a case. Step to reproduce: 1. Go to settings > technical > views (debug) 2. Find the xml homepage view (with xml_id) 3. Go to its website.page and break the m2o view_id 4. Try to create a new website, it will crash opw-2081894 closes odoo#38897 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Old outdated Odoo screenshots, and UI guidelines have no worth in the doc...
Makes it easier for users to match Odoo payments with information from the Stripe dashboard. closes odoo#39136 Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
closes odoo#39180 X-original-commit: 25d6e9a Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Was comparing b'0x02' and '0x02' closes odoo#39206 X-original-commit: 838cb0e Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Commit odoo@68d71b8 introduced a wrong domain Falsy m2m must be explicited and put outside of the "in [ids]" leaf This commit corrects it OPW 2090865 OPW 2091449 OPW 2091778 OPW 2091778 closes odoo#39208 Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
In the leaves app, you can create an allocation request where you can
select a leave type.
Before this commit:
- The leaves type order is not correct when you have a lot of them.
You should have your remaining leaves on the top of the list
and for the leaves who has 0 remaining they should be at the end
of the list.
When you click on search more, the order is correct.
After this commit:
- The leaves type order is correct.
Odony's comment: Leave types are reordered after each search(), based on
some context-dependent, non-stored conditions. The problem is that the
initial search() applies the given *limit*, so the "post-sort" will only
sort a limited number of random result from the initial search,
rather than all types matching the domain.
If you have more than 7 leaves types matching the domain, you have a
chance that the m2o auto-completion on the leave request form will not
suggest the correct leave types, because the post-sort will not even
receive them. So you may not see a leave type for which you have
remaining leaves!
OPW-2089593
closes odoo#39158
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Co-authored-by: odony <odo@odoo.com>
Some external ids of account.fiscal.position.tax.template were duplicated closes odoo#38843 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
When duplicating maintenance request, the stage should be reset to the first one (which is +/- what the default does). Fixes odoo#38558 closes odoo#38573 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
The message was not evaluted closes odoo#38578 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
closes odoo#36149 closes odoo#39192 Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com> Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
- Create a product A with a barcode, UOM as 'Unit(s)' with a BOM - Create a MO for A with more than one unit, validate - Print the 'Finished Product Label (PDF)' A single label is printed for all units, although it is not logical: a label should be printed for each unit, as already done for the Zebra labels. In case the product UOM is 'Unit(s)', we print a label per unit. At the same time, we remove useless horizontal lines. opw-2091663 closes odoo#39247 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
In e-commerce module, when you have a free product and 2 delivery
methods:
- Free
- Any delivery method with a fixed price
When you confirm your cart, you have to choose a payment method.
If you select "free delivery" and "wire transfer":
Before this commit:
- You get an internal server error
After this commit:
- You are redirected to the wire transfer confirmation
OPW-2083778
closes odoo#39304
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
To reproduce this issue, a transaction retry must be forced:
— Put a breakpoint in a line of the function process_bank_statement_line
in addons/account/models/reconciliation_widget.py;
— Open the bank statement reconciliation;
— Click in validate;
— When the code is in pause;
— Open psql and modify a line of the database that affects the current
reconciliation, for example you can change the partner_id of the
table account_bank_statement_line for the line that is modified in
https://github.com/odoo/odoo/blob/3e2d968c55542426746b287c556b5fb05d59fdcb/addons/account/models/reconciliation_widget.py#L35;
— Continue the process;
— This will generate an 'ERROR: could not serialize access due to
concurrent update' and a transaction retry.
Before this commit, a KeyError is raised, this occurs because
counterpart_aml_id was deleted from the dictionary in the first passage,
then when in the second passage triggered by the 'retry transaction',
counterpart_aml_id doesn't exist any more in the dictionary.
Now, the data is copied and there is no problem when the 'retry
transaction' is called.
Fixes odoo#23816
opw-2085822
closes odoo#39314
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Werkzeug 0.15 modified ProxyFix such that by default it only forwards the REMOTE_ADDR when enabled, whereas before 0.15 it would also forward scheme and host. This breaks proxied odoo as the base url becomes incorrect (cf odoo#34412). Use properly configured ProxyFix when running with werkzeug 0.15, old configuration otherwise. Backport of 4057227 which was merged in master, because many people apparently run 0.15 now. Closes odoo#35085 closes odoo#36212 closes odoo#37709 Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
closes odoo#39335 X-original-commit: 7ae417a Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Steps to reproduce the bug: - Create an event E with max available seats = 1 - Register to E with public user and leave the cart - In backend, register an attendee for E and confirm it - Go to the cart, try to update the line with the registration Bug: The line was not updated to 0 and so the customer had to buy an unavailable ticket. opw:2091720 closes odoo#39338 Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
closes odoo#39139 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Ref: https://en.wikipedia.org/wiki/Tanzanian_shilling opw-2091857 closes odoo#39271 X-original-commit: 4dbe922 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Before this commit, the calendar searched records on the wrong time ranges which did not take into account the timezone of the user It obviously resulted in some records not being there After this commit, all the relevant records are fetched according to the right time range in UTC, corresponding to start/end of the week/month/day of the calendar OPW 2076114 closes odoo#39240 X-original-commit: 70ed3d5 Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Steps to reproduce the bug: - Install belgian accounting - Create a tax REC with a fixed amount and affect base of subsequent taxes - Create an invoice I with a line L - Set the following taxes on L: REC (first position) and 0% EU G (second position) - Validate the I - Check the generated journal entries Bug: The account move line for REC didn't have the 0% EU G on the applied taxes field. opw:2089240 closes odoo#39323 Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Reproduce this issue:
- Go in the lunch module
- Create several orders for the same vendor
- Go in "previous orders"
- Select them and click on "actions > Lunch: Order meals"
A traceback appears, no mail is sent and the status change to
"ordered".
Cause:
The `order` method in the lunch module returns an action but without
enough information to send the mail correctly.
This commit add the missing information.
OPW-2118041
closes odoo#39959
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
closes odoo#39977 X-original-commit: 75b1d41 Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
Prerequisites
- Configure a mail server (incoming)
- Enable leads in CRM app
- Create a sales team with a mail alias (ex: testcrm@odoo.com)
and check "Pipeline" and "Leads"
- Set a partner email with one of yours (ex: bob@odoo.com) /!\
- Send a mail from bob to testcrm
- In the incoming mail server click on "Fetch"
Reproduce the issue:
- Convert the generated lead to an opportunity
- Choose "Existing customer" and set another one than the actual
- The opportunity is created but the customer is the old one
Cause:
The given partner_id is overriden by the old one in the
`handle_partner_assignation` method.
This commit gives the priority to the new partner_id.
OPW-2089404
closes odoo#40001
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Since the deployement of the forward-port bot, chances to merge code with conflict markers has greatly increased. With this commit, a new test is added to grep for those markers in most common code files. closes odoo#39984 X-original-commit: 80f22f9 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
- Create the following invoice: Line 1: price 0.50, tax 15 %, analytic account set Line 2: price 0.10, tax 15 %, analytic account set - Validate - Go to the journal entry, cancel it - Edit the entry, remove an analytic account The tax line is recomputed from 0.10 to 0.09. This is because the onchange performs the tax computation on all grouped lines at once, which is equivalent to a 'round globally' configuration. We need to split the logic depending on the tax calculation rounding method. opw-2117398 closes odoo#39960 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Firstly bd49f9f did some fixes that removed a bunch of code containing 'install_mode_data'. Later, 627292f replaced 'install_mode_data' for 'install_filename'. Finally, 43dd9ec reverted bd49f9f (including 'install_mode_data' remnant). closes odoo#39992 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
instead we do a simple try/except and catch the ValueError closes odoo#40014 X-original-commit: ed20951 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
From Sale create a new (or edit) SO. Add a note to the order with a long line without dash or whitespace (i.e. a url). Save. The table will adapt to display the long note on one line, shifting right all the headers, creating an ugly and long overflow scrollbar. Adding a "break-all" rule to mimic the behavior introduced in a32aa05 opw-2088589 closes odoo#40009 Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>
Fixes odoo#39358 Before this commit Internal user (With no other Rights) cannot perform any activity on Reminder Popup due to missing rights to set calendar_last_notif_ack field. With this fix, we are now using sudo to write calendar_last_notif_ack closes odoo#39407 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
In case of a multi-record and multi-page (i.e. 2 pages per PDF) report the assertion is triggered b/c we have 4 pages and only two records with a PDF of 2 pages each, so the outline_page needs to be unique before assertion. len([0, 0, 2, 2]) != len([record_id1, record_id2]) len([0, 2]) == len([record_id1, record_id2]) closes odoo#39701 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Reproduce this bug: - Install Contacts & Members app - Create a Membership product - Go on any contact, in the membership tab then buy membership The "current membership status" should use the first valid line. When you cancel a membership line, the current membership status is always on "cancelled". Causes: - The `_compute_state` state method is not fetching the credits notes correctly. - The `break` statement is at the wrong place. OPW-2093825 closes odoo#39803 Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Commit 5fcf891 introduced optimizations for name_search in several models. However, that produces some counter-intuitive searches. In a DB with project and custom data: >>> Project = self.env['project.task'] >>> Project.search([('user_id', 'ilike', 'demo')]).mapped('user_id.name') ['Marc Demo'] >>> Project.search([('user_id', 'not ilike', 'demo')]).mapped('user_id.name') ['Marc Demo'] The projects returned with 'not ilike' are a super-set of those returned with 'ilike': >>> Project.search([('user_id', 'ilike', 'demo')]) project.task(22, 21, 20, 16, 14, 13) >>> Project.search([('user_id', 'not ilike', 'demo')]) project.task(22, 21, 29, 28, 27, 26, 25, 20, 16, 14, 13, 31, 30) This commit fix this behaviour by choosing '!=' instead of '=' whenever the operator is a negation operator. The 'res.users' is more exposed than the other models touched by 5fcf891, because user may search for 'Created by' in the web client. closes odoo#32561 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
When using the flamegraph module from a parent directory of odoo, the dirname method returns a relative path, leading to a traceback. With this commit, the odoo_path is enforced to be an absolute path. closes odoo#40112 X-original-commit: 1a68095 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Reproduce the issue: - Install eCommerce app - Publish a product to your website - Add the product in your cart - Unpublish/make unsellable/archive the product The product is still in the cart and the checkout process can be done. Cause: There is no check for invalid products before displaying the cart This commit remove the invalid products while loading the cart. OPW-2092541 closes odoo#39931 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
self.env.user returns the current user but browsed with the superuser: - self.env.user == current user - self.env.user.env.user == administrator get_context uses self.env.user to retrieve the context of the user. Before this patch, the name of the filters was translated in the language of the administrator instead of the current user. Closes odoo#40086 closes odoo#40127 X-original-commit: 28ab5cb Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
…ssion Fine tuning of this commit: f93fcaf Steps to reproduce the bug: - Open runbot v11 - Restrict Demo's access to Sales Manager for sales and employee for Employee - Try to create a new quotation Bug: - You got Odoo server Error Sorry, you are not allowed to access this document. Only users with the following access level are currently allowed to do that: - Inventory/User - Accounting & Finance/Billing - Purchases/User - Purchases/Manager - Other Extra Rights/Portal (Document model: purchase.order.line) - (Operation: read, User: 5) opw:2120692 closes odoo#40138 X-original-commit: 1b14af2 Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Steps to reproduce the bug: - Let's consider two storable products P1 and P2 from the same vendor V - P1 and P2 have the routes 'Buy' and 'Make to order' - Create a SO for 1 P1 and 1 P2 and confirm it - A delivery order DO has been created - A PO has been created for V, confirm it - Process the shipment, receive 1 P1 and 0 P2 with no backorder - Process DO with no backorder - Return DO by clicking on 'Return' button Bug: 1 P1 and 1 P2 were suggested to be returned but the movement for P2 had been canceled. Closes odoo#39547 opw:2116582 closes odoo#40145 X-original-commit: 00fdd5f Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Before that, draft entries were taken into account in reconciliation propositions; which made no sense. 12.0 version of odoo#39954 closes odoo#40148 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Fields `Nome` and `Cognome` cannot be identical. However, Odoo has only a single field for name. Therefore, we split the name based on the assumption that the name is written as 'Name Surname'. opw-2093035 closes odoo#40037 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
_action_done() creates extra stock move when quantity_done is superior to initial demand. This extra move should be, after confirmation, either merge into the original stock_move, either stay extra but the move lines still linked to the first one should be shared accordingly to the quantity done. The fix 561b346 adapted the code for MRP to split the move lines but neither those cases are applied in MRP because the extra move has no picking_id field. condition : ```if merge_into_self and extra_move.picking_id:``` will therefore be false as well as ```if not merge_into_self:``` To be sure the two extra move management cases are complementary, this Commit keeps make sure the conditions are mutualy exclusive. closes odoo#39121 Opw: 2087864 Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Without this commit, if you have the hr_timesheet installed, the one2many analytic lines view (in the Journal Items form) shows the hr_timesheet_line_tree view instead, which is not desired. closes odoo#39749 X-original-commit: 85e1c33 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Do not insert variable inside a translated message, it will not be translated. Fixes odoo#40178 closes odoo#40191 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Usecase to reproduce: - Create a BoM with 2 components for a final product - Create a MO for 100 final products - Produce 50 - Post Inventory - Update the MO quantity to 200 - Produce 50 more The total quantity for components consumed is 175 (instead of 200) It happens because the update quantity do not take care of existing produced unit when it updates the raw material moves and their unit factor. (FYI unit factor is used later in order to know the quantity to consume depending the produced quantity) Fix odoo#39866 closes odoo#39990 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
…m valuation adjustment line.
…on is tracked by lot or serial number
alan196
pushed a commit
that referenced
this pull request
May 10, 2020
Steps to reproduce:
1. Open sales on mobile
2. Click on the search icon (with breadcrumb)
Issue #1:
The displayed cross on the right suggests to users that it's
used to close the facets but it's not.
We replace it by a back arrow to close the search like in other
apps.
3. Click on create 'Create'
4. Select a customer (Without breadcrumb)
Issue odoo#2:
We don't have any breadcrumb inside the control_panel,
so we should always display the search. There is no
need to open/close it.
Task ID: 2200099
closes odoo#46086
Related: odoo/enterprise#9486
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
AbelJarsa
pushed a commit
that referenced
this pull request
Mar 31, 2023
Issue #1: reading textContent When reading the textContent property of an element, its does not take into account line breaks introduced by <br> and block elements, whilst innerHtml does. This commit solves the issue of updating a link's href to a non-sense url upon label change. Before this commit, "www.abc.com <br> www.xyz.com" was being incorrectely parsed as "www.abc.comwww.xyz.com". Issue odoo#2: setting textContent When setting the textContent property of an element, all of its child nodes are removed and replaced by a single text node. While this is fine when the element contains a single text node, it might not be the desired result when the element contains other children. This commit solves the issue obtained when pasting html such as "link.com<br>link.be" inside an empty inline element such as STRONG or A, in which cleanForSave was changing its content (removing the line-break) due to misuse of textContent, when the intended effected was simply removing ZeroWidthSpace characters. A safer alternative for removing ZeroWidthSpace is thus provided. task-3081254 closes odoo#108521 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
35 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.