Use vp9+webm video tagged with bt601 instead of undefined colorspace. - #2240
Merged
Conversation
Firefox chooses bt709 for vp9 when colorspace isn't tagged on a file. Tagging the colorspace as bt601 causes textures/video/* to pass in Firefox.
Member
|
Thanks, nice! Tested on Chrome on macOS and Windows; still working there. Out of curiosity, what tool did you use to do the transcoding? Could you put the command line you used here? Merging now. |
Contributor
Author
|
My colleague Thomas Daede from the Daala team handled it. I will ask. |
xingri
pushed a commit
to xingri/WebGL
that referenced
this pull request
Jan 6, 2017
…KhronosGroup#2240) Firefox chooses bt709 for vp9 when colorspace isn't tagged on a file. Tagging the colorspace as bt601 causes textures/video/* to pass in Firefox.
Contributor
Author
|
We used vpxenc to just re-encode the video explicitly tagging as bt601. |
Contributor
|
This pr caused some video related fail. I fixed them at #2247. |
Collaborator
Does this actually do a color space conversion from bt709 or does it simply label the video as bt601? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox chooses bt709 for vp9 when colorspace isn't tagged on a file.
Tagging the colorspace as bt601 causes textures/video/* to pass in Firefox.