[pull] master from getsentry:master#2006
Merged
Merged
Conversation
closes https://linear.app/getsentry/issue/DE-1256/migrate-componentsteamscreateteamformtsx-from-legacy-form-system --------- Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
## Summary - Replace `SchemaHintsContainer` and `SchemaHintOption` styled components with `Flex` and `Container` Scraps layout primitives. - Replace `HintName`/`HintOperator`/`HintValue` styled spans with `Text` Scraps primitive (using `variant="muted"` and `variant="accent"`). - Update the hidden measurement code to clone the new `<Container><Button/></Container>` wrapper and set the button's inner text so the measured width still includes button chrome.
…5161) Add `get_eap_transaction_volumes()` to retrieve per-project transaction volumes from EAP spans, with optional ordering (`order_by_volume`) and `max_transactions` limit. Uses the existing `run_eap_spans_table_query_in_chunks()` for batched iteration. Replaces #115047 (which got corrupted during a rebase). Closes https://linear.app/getsentry/issue/TET-2306/create-transaction-volume-query-for-eap --------- Co-authored-by: Claude Sonnet 4 <noreply@example.com> Co-authored-by: Simon Hellmayr <shellmayr@users.noreply.github.com> Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Replace manual Project queryset with self.get_projects() to reuse the existing helper already used across OrganizationEndpoint subclasses.
these routes were not accessible in the UI and not linked to from anywhere fixes DE-1001 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
) The command palette's theme switching uses `useMutateUserOptions`, which optimistically updates `config.user.options.theme` but never updates the derived `config.theme` field that `ThemeAndStyleProvider` reads. On the first dark→light switch after page load, the theme object stays stale until `useColorscheme`'s `useEffect` catches up a frame later, causing some tokens to not update. Set `config.theme` directly in `onMutate` for non-system theme changes, matching the pattern already used by `updateUser` in `actionCreators/account.tsx`. fixes DE-1266 Co-authored-by: Claude Opus 4 <noreply@anthropic.com>
…ges (#116211) Adds a new `@sentry/scraps/prefer-info-text` ESLint rule that detects `<Tooltip>` wrapping text-like elements with `showUnderline` and suggests using `<InfoText>` instead. The rule ships with an autofix that rewrites simple cases automatically. Alongside the rule, this PR migrates existing violations across the codebase to use `<InfoText>` and enhances the `InfoText` component itself. **`InfoText` component enhancements** `InfoText` now accepts a `position` prop (forwarded to the underlying `Tooltip`) and a `variant` prop that controls the underline color to match the text style (e.g. muted text gets a muted underline). `variant="inherit"` falls back to the default tooltip underline color. **ESLint rule: `prefer-info-text`** Detects `<Tooltip showUnderline>` wrapping a single text-like child (intrinsic elements like `<span>`, `<abbr>`, `<Text>`, or i18n calls) and reports with an autofix that rewrites to `<InfoText>`. The rule is conservative — it skips Tooltips with unsupported props, multiple children, or non-text content. **Codebase migrations** Migrates ~15 files from the manual `<Tooltip showUnderline>` pattern to `<InfoText>`, including spend allocations, customer admin views, replay columns, and various settings pages. Also fixes a tooltip on the detectors assignee view that could never actually display, and updates test files to use `<button>` instead of `<span>` for tooltip trigger elements (accessibility). --- | Name | Before | After | | --- | --- | --- | | Tooltips hidden behind numbers | <img width="698" height="160" alt="Screenshot 2026-05-26 at 18 17 36" src="https://github.com/user-attachments/assets/472872e9-fe5f-4613-9144-9e7bcd0aab58" /> | Underlined text has a tooltip and is keyboard interactive.<br /><br /><img width="663" height="187" alt="Screenshot 2026-05-26 at 18 17 20" src="https://github.com/user-attachments/assets/9d8db496-d8a7-4495-b613-5bb0cd414fc2" /><br /><br /><img width="402" height="186" alt="Screenshot 2026-05-26 at 18 28 52" src="https://github.com/user-attachments/assets/50b5b9a3-a1f8-4d38-b783-fbb968ea6e13" /> | | Header tooltip visibility | Which headers have a tooltip? Impossible to know.<br /><br /><img width="658" height="165" alt="Screenshot 2026-05-22 at 16 12 39" src="https://github.com/user-attachments/assets/c94620d2-8f62-46bd-a28c-b8d4512146e5" /> | Two out of four headers have a tooltip, which is now clearly visible to users.<br /><br /><img width="672" height="167" alt="Screenshot 2026-05-22 at 16 12 52" src="https://github.com/user-attachments/assets/315475a3-74c2-4f23-bbdf-15ce46008df7" /><br /><br /><img width="720" height="293" alt="Screenshot 2026-05-22 at 16 13 11" src="https://github.com/user-attachments/assets/3de4b7ce-b88b-414f-aeb9-66089f0f688a" /> |
The backend `UserReportSerializer` returns `name` and `email` as `str | None`, but the frontend `UserReport` type had both as non-nullable `string`. When either field is `null`, `isSameIdentity` crashes calling `.trim()` on `null`. Updates the frontend type to match the backend and adds null-handling in `userFeedback.tsx` — optional chaining in `isSameIdentity`, null-coalescing for avatar fallbacks, and conditionally rendering the email copy button. Fixes JAVASCRIPT-3A0C
github-actions
Bot
added
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )