Cleanup it tests#36
Merged
tomaszmichalak merged 18 commits intomasterfrom Dec 19, 2018
Merged
Conversation
This was referenced Dec 13, 2018
tomaszmichalak
requested changes
Dec 13, 2018
Member
|
Good job! |
tomaszmichalak
requested changes
Dec 18, 2018
| .rxSendForm(getMultiMap(formData)); | ||
|
|
||
| subscribeToResult_shouldSucceed(context, httpResponseSingle, resp -> { | ||
| assertEquals(Jsoup.parse(FileReader.readTextSafe(expectedResponseFile)).body().html(), |
Member
There was a problem hiding this comment.
Please mark io.knotx.junit.util.FileReader as deprecated.
| .rxSendForm(getMultiMap(formData)); | ||
|
|
||
| subscribeToResult_shouldSucceed(context, httpResponseSingle, resp -> { | ||
| assertEquals(Jsoup.parse(FileReader.readTextSafe(expectedResponseFile)).body().html(), |
Member
There was a problem hiding this comment.
Can we introduce util that would hide Jsoup dependency like:
String HTMLFormatter.get(String input)
String HTMLFormatter.get(URL input)
Then when we decide to change Jsoup to different engine we would not have to fix all tests.
Member
Author
There was a problem hiding this comment.
Good idea.
However, I will create assertion that checks HTML body.
Member
Author
There was a problem hiding this comment.
|
|
||
| @ExtendWith(KnotxExtension.class) | ||
| @TestInstance(Lifecycle.PER_CLASS) | ||
| public class SampleApplicationFallbackSupportIntegrationTest { |
Member
There was a problem hiding this comment.
I really like this class!
tomaszmichalak
approved these changes
Dec 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed #34 .
Motivation and Context
IT tests contained a lot of unnecessary and some tests that made them hard to understand.
Now they are cleaned up.
Types of changes
Checklist:
I hereby agree to the terms of the Knot.x Contributor License Agreement.