ci: bump actions/setup-dotnet from 4 to 5#4
Merged
Conversation
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4 to 5. - [Release notes](https://github.com/actions/setup-dotnet/releases) - [Commits](actions/setup-dotnet@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-dotnet dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
5 tasks
Layellie
added a commit
that referenced
this pull request
Jun 26, 2026
#1 (critical bug): ProcessOptimizationService.cs:80 was calling SetProcessInformation with processInformationClass=34 — the exact typo that App.OnStartup already had fixed to 4. With 34 the call returns ERROR_INVALID_PARAMETER and IGNORE_TIMER_RESOLUTION never applies, so games added to Game Mode kept getting EcoQoS-throttled to 1–15.6 ms in the background, defeating the whole point of the 0.5 ms global lock for those processes. Replaced both call sites (this one and App.xaml.cs) with a new NativeMethods.ProcessPowerThrottling = 4 named constant so the magic number can't be re-introduced. #2: SettingsViewModel.ImportSettings now raises a SettingsImported event with the freshly loaded snapshot; MainViewModel subscribes and re-applies it via ApplySettings, so the running session updates without a restart. The localized "restart to apply" success string is now obsolete and reads just "Settings imported". #3: Removed dead code — MeasureActualResolutionMs is no longer called anywhere (the watchdog reads `current` directly from NtSetTimerResolution), and its three P/Invokes (GetSystemTimeAsFileTime, TimeBeginPeriod, TimeEndPeriod) went with it. The legacy timeBeginPeriod path had an explicit warning comment about why it must never be re-enabled. #4: ApplyTimerRequest used to register the *caller* thread as AVRT "Pro Audio" and drop the returned handle on the floor — that permanently boosted the dispatcher to MMCSS and leaked one handle per Activate cycle. The dedicated watchdog thread already does MMCSS registration AND reverts it on exit (handle stored in a local, AvRevertMmThreadCharacteristics called in finally), so the caller-thread call was both wrong (per-process kernel request, not per-thread) and leaky. Removed. #5: SyncMonitorSettings split into SyncMonitorThresholds (called on every TextBox keystroke) and SyncMonitorGames (called only when the Games collection mutates). Stops rebuilding the GamePaths list on every digit the user types into a threshold input. Bumped to 2.0.5 in csproj, Setup.iss and build-installer.ps1. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/setup-dotnet from 4 to 5.
Release notes
Sourced from actions/setup-dotnet's releases.
... (truncated)
Commits
9a946fdAdd rollForward note in README, improve proxy health check in e2e tests and b...98af08bSupport global.json's rollForward latest* variants (#538)8404272Update install scripts to v2026.05.19 (#736)f1970f5Don't download releases-index.json to resolve major version (#560)af9211bAdd dotnet-version: latest support with dotnet-channel input (#730)df991aechore: bump @actions/* and fast-xml-parser dependencies (#728)a66eefaCI: remove manual PowerShell install from test-proxy job (e2e-tests.yml) (#703)c2fa09fBump minimatch from 3.1.2 to 3.1.5 (#705)02574b1Add support for optional architecture input for cross-architecture .NET insta...16c7b3cBump fast-xml-parser from 4.4.1 to 5.3.6 (#671)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)