Add cross-size covariance audit and research diagnostics - #46
Add cross-size covariance audit and research diagnostics#46LightChainr wants to merge 9 commits into
Conversation
11bd6b5 to
7d73a2f
Compare
|
Independent execution review completed on
Measured cross-size correlations are real but moderate (roughly -0.18 to +0.26 across the retained metrics). They do not reverse the radial conclusion:
For A_p, the full-covariance training amplitude is Recommendation: merge the audit tool. Commit its generated P33 audit outputs before selecting the #39 replay policy, and keep both diagonal/full scores in the report as specified. |
|
Follow-up after the branch was rewritten to
The merge recommendation remains positive. One nonblocking integrity improvement: |
Review: methodology is sound; add four robustness gates before interpreting the outputThe main correction is correct: aligned cross-size batches must be treated jointly, nonlinear root gaps should use delete-one jackknife pseudo-values, and the held-out residual covariance must include covariance between the fitted training amplitude and held-out observations. Before this becomes the authoritative P33/P35 score, please add or explicitly report the following. 1. Equal-batch-weight contract
Either:
Do not silently give unequal batches equal statistical weight. 2. Near-singular covariance handlingCommon counter streams can make the cross-size covariance nearly singular. The current hand-written Gauss–Jordan inverse should not be the only path used for scientific scores. Please emit:
A failed inversion or large condition number is itself a result and should remain in the report. 3. Estimated-covariance calibrationThe reported quadratic form uses a covariance matrix estimated from about 100 batches. Label the resulting chi-square as a plug-in/asymptotic score. Add at least one of:
This matters most for the two-dimensional held-out test when the covariance has strong off-diagonal structure. 4. Stronger synthetic regressionThe current cross-covariance test verifies that the residual off-diagonal is nonzero and the score is finite. Add a synthetic case with an analytically known answer where off-diagonal training/held-out covariance materially changes the fitted amplitude or held-out score. Assert the exact expected full-covariance and diagonal-only values. Requested result artifactAfter these gates pass, run the audit on the committed P33 histogram and commit: The report should compare, for both
Do not overwrite the previous analysis. This audit should determine whether the apparent radial root-amplitude tension survives the actual coupling policy. |
7d73a2f to
75ee2f6
Compare
LightChainr
left a comment
There was a problem hiding this comment.
Result review: scientific conclusion is now clear; robustness requirements remain open
The committed P33 audit answers the immediate scientific question. Cross-size correlations are real but modest and mixed-sign (the largest absolute values are about 0.22). Including them does not materially change the previous low-stat radial conclusions:
A_M held-out chi2: full 5.5300 / 2; diagonal 5.2733 / 2
A_p held-out chi2: full 5.5516 / 2; diagonal 5.2929 / 2
root doubling: full 3.4625 / 2; diagonal 3.4417 / 2
Thus the old diagonal approximation was not the source of the apparent P33 radial/root tension. The P33 data are simply underpowered/noisy for those asymptotic questions. This is an important negative audit result.
The implementation correctly uses delete-one jackknife pseudo-values for nonlinear roots and propagates training/held-out cross-covariance. The result files and workflow are useful and should be retained.
However, the four robustness gates from the earlier review are still not implemented in the current head:
_orientation_batches()checks equal samples only between first/second orientations inside one(N,batch), not a common batch weight across all aligned sizes. Assert one common sample count for the complete matrix or implement explicit weights.- Scientific scores still rely on a hand-written Gauss–Jordan inverse. Emit eigen/singular values, condition number/effective rank, and use a stable Cholesky/SVD/pseudoinverse path.
- The chi-square values remain plug-in/asymptotic with covariance estimated from 100 batches. Add batch-bootstrap or an explicit finite-batch calibration/sensitivity table.
- The synthetic off-diagonal test still checks only that a covariance entry is nonzero and the score is finite. Add an analytically known example asserting exact full-covariance and diagonal-only amplitudes/scores.
I therefore regard the empirical audit conclusion as valid, but not yet the general-purpose scoring implementation as fully hardened. After these four items, the PR is suitable as the authoritative covariance tool. Future production should preserve same-N orientation coupling while domain-separating distinct N by default, unless a prespecified pilot demonstrates useful parent/child covariance for the exact target statistic.
|
治理审查:该 PR 的 empirical archive 有价值,但当前 generic covariance/scoring path 还不应合并。阻断项如下:
这些是统计基础设施的合并门槛,不是否定已记录的经验结论。现有 cross-size correlation 结果可继续作为 provenance 保留。 |
|
已由 #69 以 current-main 单提交方式迁入:covariance audit、root-doubling diagnostics、历史输出、validator 和 tests 都已在 |
Purpose
Measure the implicit cross-size coupling in the historical P33 threshold-rank batches and preserve a covariance-aware diagnostic path on
main.This is research analysis infrastructure, not a general-purpose calibrated statistics library. Its outputs are suitable for comparing the historical full-covariance and diagonal diagnostics and for planning new runs. Strong paper-facing p-values or near-singular generic covariance cases can be hardened later if they become decision-critical.
Added
Delta M, meanM', root-gap jackknife pseudo-values,A_M,B, and angular-normalizedA_p;Current empirical takeaway
Historical P33 cross-size correlations are real but modest (maximum absolute correlation about
0.22). Using the measured covariance changes the old low-stat scores only modestly:So the old radial tension was not created by ignoring a huge hidden cross-size correlation.
Scope
For the committed archive the batch design is aligned and validated. Future production should use the simpler policy in #39: domain-separate distinct
Nby default, or retain deliberate coupling with aligned batches when covariance reduction is useful.Numerical hardening such as rank-aware pseudoinverses or finite-sample calibration is welcome follow-up work, but it is no longer a merge blocker for this exploratory audit.