February 14, 2019

Jump to bottom

Charles edited this page Feb 15, 2019 · 3 revisions

Attendees

Charles, Line,
Oumar, Steffan, Hassan

Objectives of meeting

Present our email template feature to the teacher and TA.

Notes

Release 1 meeting notes
- Comments about the code:
  - Refactor the hardcoded messages for the templates. Teacher suggested putting them in the config file.
- Comments about testing:
  - assertEquals should be moved inside @Test. Fix this.
  - Test needs to be better for the next release meeting. Teacher said to mock the object and trigger the event and test the method.
- Comments about commits:
  - Always link every commit to an issue.
  - Assign multiple people to review code.
  - More discussion on Github. Especially for every pull request.
  - Write rules to follow for passing pull requests in a markdown file or in the READ.md
- Comments about Travis.ci:
  - yml file. There should be two stages for every jobs.

SIDE NOTE:

Create an issue to refactor the code.

Next meeting will be the release meeting on February 15, 2019.