Change to mask directory instead of individual mask files #289

xylar · 2017-12-10T18:04:22Z

The name of the MOC mask file is constructed automatically from the
mesh name.

This approach is needed in anticipation of having other region masks (notably masks for individual ice shelves, see #237)

Example config files have been updated accordingly.

The name of the mask file is constructed automatically from the mesh name.

xylar · 2017-12-10T18:05:19Z

This needs to be merged before #237 and #246

xylar · 2017-12-10T18:08:12Z

xylar · 2017-12-10T20:53:19Z

@milenaveneziani, could you check the 3 configs on OLCF by making sure the MOC gets computed correctly when you run the analysis? I need to get myself set up on titan and rhea but I'm not there yet. I'd like to make sure the region mask files there have the right naming convention. I had to fix the names on LANL IC and theta.

milenaveneziani · 2017-12-11T19:31:24Z

@xylar: I am testing with the config files you listed on titan. First test (18to6 run) failed because I don't have permission to read the model data (I have asked @vanroekel to change permissions when he has a chance), but I have changed the region mask filename in a way that is compatible with how this PR expects it. Second test (beta1 run) passed. Third test (beta2 run) is going, but I found a tiny typo in the corresponding config file: I will point it to you in the review section.

milenaveneziani · 2017-12-11T19:35:38Z

configs/edison/config.B_low_res_ice_shelves_1696_JWolfe_layout_Edison

 [timeSeriesSeaIceAreaVol]
 ## options related to plotting time series of sea ice area and volume

 # plot on polar plot


Could you add these lines in this file, right before line 46:

# provide an absolute path to put HTML in an alternative location (e.g. a web # portal) # htmlSubdirectory = /global/project/projectdirs/acme/www/USERNAME/RUNNAME htmlSubdirectory = html

milenaveneziani · 2017-12-11T19:37:46Z

configs/olcf/config.20170313.beta1.A_WCYCL1850S.ne30_oECv3_ICG.edison

 #                                      ./run_mpas_analysis --list
 #                                   to list all task names and their tags
 # an equivalent syntax can be used on the command line to override this
 # option:


Could you add these, right before line 35:

# provide an absolute path to put HTML in an alternative location (e.g. a web # portal) # htmlSubdirectory = /ccs/proj/cli115/www/USERNAME/RUNNAME htmlSubdirectory = html

milenaveneziani · 2017-12-11T19:40:14Z

configs/olcf/config.20170915.beta2.A_WCYCL1850S.ne30_oECv3_ICG.edison

 ## circulation (MOC)

 # Region names for basin MOC calculation.
 # Supported options are Atlantic and IndoPacific


Could you change mpasMeshName to oEC60to30v3?

And then add, before line 54:

# provide an absolute path to put HTML in an alternative location (e.g. a web # portal) # htmlSubdirectory = /ccs/proj/cli115/www/USERNAME/RUNNAME htmlSubdirectory = html

I think you forgot to adjust the mpasMeshName.

Yes, I missed that. I'll fix it now.

milenaveneziani · 2017-12-11T19:44:34Z

configs/olcf/config.GMPAS-IAF_oRRS18to6v3.titan

 #                                      ./run_mpas_analysis --list
 #                                   to list all task names and their tags
 # an equivalent syntax can be used on the command line to override this
 # option:


This one is missing a few things (mind you, I haven't had a chance to test this yet, because of the nco problems with large files, which I mentioned in the email):

as noted by @vanroekel, the input baseDirectory should be changed to /lustre/atlas1/cli115/proj-shared/vanroek/run

mpasMeshName

there is the piece with Directory with mapping files, but not this newer part:

# Directory for region mask files regionMaskDirectory =

these lines before line 37:

# provide an absolute path to put HTML in an alternative location (e.g. a web # portal) # htmlSubdirectory = /ccs/proj/cli115/www/USERNAME/RUNNAME htmlSubdirectory = html

I do see the regionMaskDirectory part in my version at the bottom. I have changed the rest as you suggested.

milenaveneziani · 2017-12-11T19:45:12Z

configs/theta/config.20171031.tenYearTest.GMPAS-IAF.T62_oEC60to30v3wLI.60layer.theta

+regionMaskDirectory = /projects/OceanClimate/mpas-analysis_data/mpas_analysis/region_masks

 [climatologyMapSoseTemperature]
 # Times for comparison times (Jan, Feb, Mar, Apr, May, Jun, Jul, Aug, Sep, Oct,


do we have a htmlSubdirectory on theta?

No, as far as I'm aware, there's no web portal on theta.

milenaveneziani · 2017-12-11T19:46:20Z

Test with beta2 run also passed. I am down to testing the high-res case.

vanroekel · 2017-12-11T19:57:35Z

@milenaveneziani, FYI that the high res data on titan is now at

/lustre/atlas1/cli115/proj-shared/vanroek/run

milenaveneziani · 2017-12-12T14:35:02Z

@xylar: after changing the mpasMeshName in one of the config files, you can merge this.

Although the olcf config file for the high-res cannot be tested for the MOC right now, due to the need for nco 4.7.0, I have changed the MOC transect filename for the RRS18to6 to reflect changes here, so we shouldn't have problems when the time comes.

Remove --purge option from job scripts

xylar · 2017-12-12T16:16:15Z

@milenaveneziani, I really appreciate your efforts on the RRS18to6. We'll get it working but I agree that it shouldn't hold up this PR as long as we're pretty sure the config file will be correct once we get it working.

Merges PRs #282, #285, #287, #289, #290, #291, #293, #295, #288, #296, #237, #297, #294, #300 and #292

Change to mask directory instead of MOC mask file

20d577c

The name of the mask file is constructed automatically from the mesh name.

xylar added the enhancement label Dec 10, 2017

xylar self-assigned this Dec 10, 2017

xylar requested a review from milenaveneziani December 10, 2017 18:04

xylar added clean up priority labels Dec 10, 2017

xylar force-pushed the switch_to_mask_directory branch 3 times, most recently from 8172aad to 3d79120 Compare December 10, 2017 20:50

xylar mentioned this pull request Dec 11, 2017

Add antarctic melt time series #237

Merged

milenaveneziani reviewed Dec 11, 2017

View reviewed changes

xylar force-pushed the switch_to_mask_directory branch from 3d79120 to 01d9f83 Compare December 12, 2017 08:53

milenaveneziani approved these changes Dec 12, 2017

View reviewed changes

Update example config files with mask directories

b7adb36

Remove --purge option from job scripts

xylar force-pushed the switch_to_mask_directory branch from 01d9f83 to b7adb36 Compare December 12, 2017 16:14

xylar merged commit ced7dda into MPAS-Dev:develop Dec 12, 2017

xylar deleted the switch_to_mask_directory branch December 12, 2017 16:19

milenaveneziani mentioned this pull request Dec 12, 2017

Add analysis tasks for plotting SOSE T and S #288

Merged

xylar mentioned this pull request Jan 26, 2018

Merge develop to master #302

Merged

xylar added a commit that referenced this pull request Jan 26, 2018

Merge develop to master

e56da52

Merges PRs #282, #285, #287, #289, #290, #291, #293, #295, #288, #296, #237, #297, #294, #300 and #292

Change to mask directory instead of individual mask files #289

Change to mask directory instead of individual mask files #289

Uh oh!

Conversation

xylar commented Dec 10, 2017

Uh oh!

xylar commented Dec 10, 2017

Uh oh!

xylar commented Dec 10, 2017 • edited by milenaveneziani Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xylar commented Dec 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

milenaveneziani commented Dec 11, 2017

Uh oh!

milenaveneziani Dec 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

milenaveneziani Dec 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

milenaveneziani Dec 11, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

milenaveneziani commented Dec 11, 2017

Uh oh!

vanroekel commented Dec 11, 2017

Uh oh!

milenaveneziani commented Dec 12, 2017

Uh oh!

xylar commented Dec 12, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

xylar commented Dec 10, 2017 •

edited by milenaveneziani

Loading

xylar commented Dec 10, 2017 •

edited

Loading

milenaveneziani Dec 11, 2017 •

edited

Loading

milenaveneziani Dec 11, 2017 •

edited

Loading

milenaveneziani Dec 11, 2017 •

edited

Loading