fix(design): migrate orphan --theme-dim* and --theme-text-accent refs#11332
Closed
Conversation
Phase 4's primitive removal dropped --theme-dim, --theme-dim-light, --theme-dim-lighter, and --theme-text-accent from theme.css's semantic layer, but a handful of consumers still referenced these tokens. With the definitions gone, the references would silently fall back to their initial values (transparent / inherit), causing invisible scrollbars, broken focus outlines, and lost border affordances. Migrate the orphan references to live semantic tokens: - --theme-dim-light → --theme-border (scrollbar tones) - --theme-dim-lighter → --theme-divider (subtle borders) - --theme-text-accent → --theme-link (code-in-link, focus outline) Affected files: - src/styles/index.css - src/components/Search/Search.astro - src/components/ScrollToTop.astro - src/components/Header/SidebarToggle.css Change-Id: Ie5f5458a2f7c9ee096b5d4dfdc90c2b6c5603ead
This was referenced Apr 30, 2026
Member
Author
|
This pull request is part of a Mergify stack:
|
This was referenced Apr 30, 2026
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ⛓️ Depends-On RequirementsWaiting for:
This rule is failing.Requirement based on the presence of
🔴 👀 Review RequirementsWaiting for:
This rule is failing.
🔴 🔎 ReviewsWaiting for:
This rule is failing.
🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
jd
deleted the
devs/jd/worktree-design/migrate-orphan-theme-dim-theme-text-accent-refs--e5f5458a
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4's primitive removal dropped --theme-dim, --theme-dim-light,
--theme-dim-lighter, and --theme-text-accent from theme.css's semantic
layer, but a handful of consumers still referenced these tokens.
With the definitions gone, the references would silently fall back to
their initial values (transparent / inherit), causing invisible
scrollbars, broken focus outlines, and lost border affordances.
Migrate the orphan references to live semantic tokens:
Affected files:
Depends-On: #11331