fix(design): address Phase 4 code review findings#11333
Closed
Conversation
- Migrate orphan section-accent references in AcademyCallout, the merge-queue inline-style stat cards, and changelog/index.astro to direct product palette tokens (teal-700/400, rose-700/400, purple-700/400, blue-700/400 with color-mix bg variants). Phase 4's collapse of the per-section accent block deleted the named tokens these consumers were reading; without this fix they would silently render as transparent. - Replace Chakra-era thead hex literals (#4a5568, #a0aec0) with var(--theme-text-secondary). The semantic token already remaps in dark mode so the .theme-dark override block becomes redundant. - Use var(--theme-divider) for the scrollbar thumb and Firefox track color instead of var(--theme-border). The previous mapping was a visible regression in dark mode where --theme-border resolves to gray-700 (medium dark gray, very visible) rather than the original near-invisible scrollbar tone. Change-Id: I974093ba74a745dde26e2ff3f681ea9e198fd7a8
This was referenced Apr 30, 2026
This was referenced Apr 30, 2026
Member
Author
|
This pull request is part of a Mergify stack:
|
Contributor
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🔴 ⛓️ Depends-On RequirementsWaiting for:
This rule is failing.Requirement based on the presence of
🔴 👀 Review RequirementsWaiting for:
This rule is failing.
🔴 🔎 ReviewsWaiting for:
This rule is failing.
🟢 🤖 Continuous IntegrationWonderful, this rule succeeded.
🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 📕 PR descriptionWonderful, this rule succeeded.
|
jd
deleted the branch
devs/jd/worktree-design/migrate-orphan-theme-dim-theme-text-accent-refs--e5f5458a
jd
deleted the
devs/jd/worktree-design/address-phase-4-code-review-findings--974093ba
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate orphan section-accent references in AcademyCallout, the
merge-queue inline-style stat cards, and changelog/index.astro to
direct product palette tokens (teal-700/400, rose-700/400,
purple-700/400, blue-700/400 with color-mix bg variants). Phase 4's
collapse of the per-section accent block deleted the named tokens
these consumers were reading; without this fix they would silently
render as transparent.
Replace Chakra-era thead hex literals (#4a5568, #a0aec0) with
var(--theme-text-secondary). The semantic token already remaps in
dark mode so the .theme-dark override block becomes redundant.
Use var(--theme-divider) for the scrollbar thumb and Firefox track
color instead of var(--theme-border). The previous mapping was a
visible regression in dark mode where --theme-border resolves to
gray-700 (medium dark gray, very visible) rather than the original
near-invisible scrollbar tone.
Depends-On: #11332