Skip to content

fix: Polish Design System Engineers toast for 8.6.0 release - #33765

Closed
amandaye0h wants to merge 1 commit into
mainfrom
toast-8.6.0/polish-design-system-engineers
Closed

fix: Polish Design System Engineers toast for 8.6.0 release#33765
amandaye0h wants to merge 1 commit into
mainfrom
toast-8.6.0/polish-design-system-engineers

Conversation

@amandaye0h

@amandaye0h amandaye0h commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Polishes Design System Engineers toast call sites for the 8.6.0 release so they align with the shared toast pattern (Confirmation icon, success/error icon colors, and default toast chrome instead of custom background colors).

Updates the shared Toast account avatar size from Md to Sm so feature toasts render consistently with the design system polish.

Changelog

CHANGELOG entry: Polished toast styling for consistency in the 8.6.0 release

Related issues

Fixes:

Related toast polish PRs for 8.6.0:

Manual testing steps

Feature: Toast account avatar
  Scenario: toast shows account avatar
    Given a toast with an account avatar is shown
    When the toast renders
    Then the avatar uses the Sm size

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

Align Design System Engineers toast call sites with the shared 8.6.0 toast polish pattern.

Co-authored-by: Cursor <cursoragent@cursor.com>
@amandaye0h amandaye0h self-assigned this Jul 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-design-system All issues relating to design system in Mobile label Jul 24, 2026
@metamask-ci

metamask-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Related issues section is empty. Add Fixes: #123 / Closes: <URL> / Refs: <Jira key>, or write a short rationale after the colon.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@amandaye0h amandaye0h changed the title fix: Polish Design System Engineers toast for 8.6.0 release fix: Polish DS Legacy toast for 8.6.0 release Jul 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only changed file is app/component-library/components/Toast/Toast.tsx, and the diff shows a single-line change: modifying the avatar size in the Toast component from AvatarSize.Md to AvatarSize.Sm. This is a purely visual/cosmetic change with no functional impact on any user flows, business logic, navigation, or transaction processing. No E2E smoke tests directly test Toast component avatar sizing. The change does not affect any critical paths that would warrant running any specific test suite.

Performance Test Selection:
The change is a single-line visual adjustment to avatar size in the Toast component. This has no measurable impact on app performance metrics such as launch time, login speed, asset loading, or any other performance-sensitive flows.

View GitHub Actions results

@amandaye0h amandaye0h changed the title fix: Polish DS Legacy toast for 8.6.0 release fix: Polish Design System Engineers toast for 8.6.0 release Jul 24, 2026
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-XS team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant