Skip to content

fix: Polish Earn toast for 8.6.0 release - #33775

Merged
amandaye0h merged 1 commit into
mainfrom
toast-8.6.0/polish-earn
Jul 28, 2026
Merged

fix: Polish Earn toast for 8.6.0 release#33775
amandaye0h merged 1 commit into
mainfrom
toast-8.6.0/polish-earn

Conversation

@amandaye0h

@amandaye0h amandaye0h commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Polishes Earn toast call sites for the 8.6.0 release so they align with the shared toast pattern (Confirmation icon, success/error icon colors, and default toast chrome instead of custom background colors).

Updates the Cash mUSD empty-state Merkl claim error toast label to bold for consistency with other plain toasts.

Changelog

CHANGELOG entry: Polished toast styling for consistency in the 8.6.0 release

Related issues

Fixes:

Related toast polish PRs for 8.6.0:

Manual testing steps

Feature: Cash claim error toast
  Scenario: Merkl claim error
    Given a Merkl claim error occurs on the Cash empty state
    When the toast appears
    Then the error label is bold

Screenshots/Recordings

Before

Screen.Recording.2026-07-28.at.3.28.29.PM.mov

After

Screen.Recording.2026-07-28.at.3.18.29.PM.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

Align Earn toast call sites with the shared 8.6.0 toast polish pattern.

Co-authored-by: Cursor <cursoragent@cursor.com>
@amandaye0h amandaye0h self-assigned this Jul 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-design-system All issues relating to design system in Mobile label Jul 24, 2026
@metamask-ci

metamask-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Related issues section is empty. Add Fixes: #123 / Closes: <URL> / Refs: <Jira key>, or write a short rationale after the colon.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only changed file is app/components/Views/Homepage/Sections/Cash/CashGetMusdEmptyState.tsx. The diff shows a single-line change: isBold: falseisBold: true for a toast label option when displaying a Merkl claim error. This is a purely cosmetic/styling change — it only affects whether the error toast text is rendered in bold. There are no functional logic changes, no API changes, no navigation changes, and no shared component modifications. Per the cosmetic changes rule, bold/styling-only changes have zero functional impact and must not trigger additional test selection. No E2E tags are warranted.

Performance Test Selection:
The change is a single cosmetic styling property (isBold: false → true) in a toast label. This has no measurable impact on app performance, rendering times, or any performance-sensitive flows.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@amandaye0h
amandaye0h added this pull request to the merge queue Jul 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 28, 2026
@amandaye0h
amandaye0h added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit 68f1f52 Jul 28, 2026
233 of 235 checks passed
@amandaye0h
amandaye0h deleted the toast-8.6.0/polish-earn branch July 28, 2026 16:36
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 28, 2026
@metamask-ci metamask-ci Bot added the release-8.6.0 Issue or pull request that will be included in release 8.6.0 label Jul 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.6.0 Issue or pull request that will be included in release 8.6.0 size-XS team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants