Skip to content

fix: Polish Web3Auth toast for 8.6.0 release - #33774

Merged
amandaye0h merged 2 commits into
mainfrom
toast-8.6.0/polish-web3auth
Jul 28, 2026
Merged

fix: Polish Web3Auth toast for 8.6.0 release#33774
amandaye0h merged 2 commits into
mainfrom
toast-8.6.0/polish-web3auth

Conversation

@amandaye0h

@amandaye0h amandaye0h commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Polishes Web3Auth toast call sites for the 8.6.0 release so they align with the shared toast pattern (Confirmation icon, success/error icon colors, and default toast chrome instead of custom background colors).

Updates the import-SRP success toast to use the Confirmation icon with the theme success color.

Changelog

CHANGELOG entry: Polished toast styling for consistency in the 8.6.0 release

Related issues

Fixes:

Related toast polish PRs for 8.6.0:

Manual testing steps

Feature: Import SRP toast
  Scenario: SRP imported successfully
    Given the user successfully imports a secret recovery phrase
    When the success toast appears
    Then it uses the Confirmation icon with the success color

Screenshots/Recordings

Before

Screen.Recording.2026-07-28.at.3.31.28.PM.mov

After

Screen.Recording.2026-07-28.at.3.21.33.PM.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

Align Web3Auth toast call sites with the shared 8.6.0 toast polish pattern.

Co-authored-by: Cursor <cursoragent@cursor.com>
@amandaye0h amandaye0h self-assigned this Jul 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamask-ci metamask-ci Bot added the team-design-system All issues relating to design system in Mobile label Jul 24, 2026
@metamask-ci

metamask-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

  • Related issues section is empty. Add Fixes: #123 / Closes: <URL> / Refs: <Jira key>, or write a short rationale after the colon.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

… icon

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The PR changes the success toast in the ImportNewSecretRecoveryPhrase component: the icon is changed from Check to Confirmation and a green color (colors.success.default) is added via the theme. The unit test is updated to match. This is a minor UI-only change to the toast displayed after a successful SRP import.

SmokeAccounts is selected because tests/smoke-appium/accounts/import-srp.spec.ts directly tests the multi-SRP import flow (tagged SmokeAccounts) and would exercise this component's success toast. The toast icon/color change could theoretically affect any assertion on the toast's visual state.

SmokeWalletPlatform is selected per the SmokeAccounts tag description: "When changes touch multi-SRP architecture, account list, SRP export, or sync flows, also select SmokeWalletPlatform."

No other tags are needed — this change is isolated to the SRP import success toast UI and does not affect confirmations, network, swap, browser, or other flows.

Performance Test Selection:
The change is a minor UI update to a toast icon and color in the SRP import flow. This has no impact on app performance metrics such as launch time, login speed, asset loading, or account list rendering. No performance tests are warranted.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@amandaye0h
amandaye0h marked this pull request as ready for review July 28, 2026 14:47
@amandaye0h
amandaye0h requested a review from a team as a code owner July 28, 2026 14:47
@github-actions github-actions Bot added the risk:medium AI analysis: medium risk label Jul 28, 2026
@himanshuchawla009
himanshuchawla009 added this pull request to the merge queue Jul 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 28, 2026
@amandaye0h
amandaye0h added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit 217619e Jul 28, 2026
185 of 210 checks passed
@amandaye0h
amandaye0h deleted the toast-8.6.0/polish-web3auth branch July 28, 2026 17:02
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 28, 2026
@metamask-ci metamask-ci Bot added the release-8.6.0 Issue or pull request that will be included in release 8.6.0 label Jul 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-8.6.0 Issue or pull request that will be included in release 8.6.0 risk:medium AI analysis: medium risk size-XS team-design-system All issues relating to design system in Mobile

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants