3dstickerpro

[NBForgeLab]

---

[coderabbitai]

Caution

Review failed

The head commit changed during the review from d625bab to 1be29ff.

Important

Merge conflicts detected (Beta)

• Resolve merge conflict in branch 3dstickerpro

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 3dstickerpro

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[devin-ai-integration]

Devin Review found 4 potential issues.

🐛 4 issues in files not directly in the diff

🐛 Local search highlight object missing searchFilterParams key, uses wrong key matchCase (newIDE/app/src/EventsSheet/index.js:2436-2443)

When building effectiveSearchHighlight for the local search case (i.e., hasLocalSearchResults is true), the object uses matchCase instead of searchFilterParams as the SearchHighlight type requires. The SearchHighlight type at newIDE/app/src/EventsSheet/index.js:190 defines searchFilterParams: SearchFilterParams, but the local-search branch constructs an object with a bare matchCase key. This means downstream code reading effectiveSearchHighlight.searchFilterParams will get undefined, and any search filter parameters (like searchInConditions, searchInActions, etc.) will be lost for text highlighting in the local search case.

---

🐛 Navigation highlight object missing searchFilterParams key (newIDE/app/src/EventsSheet/index.js:2444-2447)

Similarly to BUG-0001, the navigation highlight branch at newIDE/app/src/EventsSheet/index.js:2444-2447 constructs an object with matchCase: false instead of searchFilterParams: { matchCase: false }. This is inconsistent with the SearchHighlight type definition at line 190 which requires searchFilterParams: SearchFilterParams. Downstream code that accesses effectiveSearchHighlight.searchFilterParams will get undefined.

---

⚠️ Global search searchInEvents call passes searchInEventSentences but SearchFilterParams doesn't guarantee it's defined (newIDE/app/src/Utils/EventsGlobalSearchScanner.js:104-114)

In newIDE/app/src/Utils/EventsGlobalSearchScanner.js:112, the code passes inputs.searchFilterParams.searchInEventSentences to gd.EventsRefactorer.searchInEvents. However, the SearchFilterParams type in newIDE/app/src/Utils/Search.js declares searchInEventSentences as optional (searchInEventSentences?: boolean). The GlobalSearchInputs type uses Required<SearchFilterParams> but only the global search form sets these values. If a caller doesn't provide searchInEventSentences, it would pass undefined to the C++ binding which may be coerced to false, silently disabling sentence-based searching. This is a minor API contract issue since the type says Required but the underlying SearchFilterParams has optional fields.

---

⚠️ setCurrentCallContextId is not reset to 0 if a wrapped method throws (GDevelop.js/Bindings/postjs.js:529-541)

In the use-after-free detection wrapper in GDevelop.js/Bindings/postjs.js, setCurrentCallContextId(wrappedContextId) is called before original.apply(this, arguments), but the reset setCurrentCallContextId(0) is only reached if the method returns normally. If the wrapped C++ method throws an exception, the context ID remains set to the throwing method's ID. This means any subsequent object destructions (e.g., in cleanup/finally blocks) will be incorrectly attributed to the method that threw. While not a crash, it degrades the accuracy of the diagnostic information this feature is specifically designed to provide.

View 6 additional findings in Devin Review.

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.