Merged
Conversation
* 3dstickerpro (#20) * Sticker3DBehavior * small fix * offset modes * fix destroy checkbox * 3dstickerpro (#21) * Sticker3DBehavior * small fix * offset modes * fix destroy checkbox * Fix a crash updating an extension when importing a GDO file and the extension tab is open (4ian#8412) - Don't show in changelog * Fix potential crashes of the Objects panel (4ian#8413) * Add Ctrl/Cmd+K as a secondary shortcut for command palette (4ian#8415) * Remove useless wiki search integration from the Command Palette (4ian#8416) * Fix embedded resource links when importing a GDO (4ian#8419) * Display better certificate errors (4ian#8421) * Fix native menu wrongly shown when right clicking a tab on the web-app * Fix native context menu wrongly shown in Events Sheets on the web-app * Fix a crash when removing a behavior while the behavior overriding is displayed in the side panel (4ian#8427) * Redesign the object/behavior configuration editor in extensions to be more compact (4ian#8425) * Update the tree of functions in extensions editor with a new set of icons (4ian#8424) * [Auto PR] Update translations (4ian#8382) * Bump to 262 (4ian#8428) * Save the scroll position of JS code events when closing and opening tabs (4ian#8417) * Add a preference to enable the display of type errors in JavaScript events (4ian#8429) * Replace SearchBar with CompactSearchBar in property and function lists (4ian#8430) --------- Co-authored-by: D8H <Davy.Helard@gmail.com> Co-authored-by: Florian Rival <Florian.rival@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Clément Pasteau <4895034+ClementPasteau@users.noreply.github.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (20)
📒 Files selected for processing (139)
📝 WalkthroughWalkthroughThis pull request introduces comprehensive improvements across multiple systems: replaces PNG icons with SVG variants in C++ extension definitions, adds memory tracking to event and object classes, refactors resource serialization with new helper methods, removes Algolia-based wiki search integration, converts UI components to compact variants throughout the IDE, enhances the JavaScript code editor with state persistence, adds secondary keyboard shortcuts, and improves extension/object import workflows. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+575
to
+579
| {(property.getType() === 'String' || | ||
| property.getType() === 'Number' || | ||
| property.getType() === 'ObjectAnimationName' || | ||
| property.getType() === 'KeyboardKey' || | ||
| property.getType() === 'MultilineString') && ( |
There was a problem hiding this comment.
🔴 Duplicate default value controls rendered for MultilineString property type
When a behavior/object property's type is MultilineString, both a single-line CompactSemiControlledTextField AND a multiline CompactTextAreaField are rendered for the "Default value" field, because 'MultilineString' is included in the condition at line 579 that guards the single-line field. The old code used a single SemiControlledTextField with multiline={property.getType() === 'MultilineString'} to dynamically switch. The new code should exclude 'MultilineString' from the first condition (lines 575-579) since the dedicated CompactTextAreaField at line 603 is the intended replacement. Additionally, the CompactTextAreaField's placeholder check property.getType() === 'Number' ? '123' : 'ABC' (line 607) is dead code since it's always inside a MultilineString guard.
Suggested change
| {(property.getType() === 'String' || | |
| property.getType() === 'Number' || | |
| property.getType() === 'ObjectAnimationName' || | |
| property.getType() === 'KeyboardKey' || | |
| property.getType() === 'MultilineString') && ( | |
| {(property.getType() === 'String' || | |
| property.getType() === 'Number' || | |
| property.getType() === 'ObjectAnimationName' || | |
| property.getType() === 'KeyboardKey') && ( |
Was this helpful? React with 👍 or 👎 to provide feedback.
| floatingLabelText={<Trans>Description</Trans>} | ||
| helperMarkdownText={i18n._( | ||
| <CompactTextAreaField | ||
| label={i18n._(`Description`)} |
There was a problem hiding this comment.
🟡 Missing t translation tag on Description label in EventsBasedBehaviorEditor
At line 106, the label uses i18n._(`Description`) (a plain template literal) instead of i18n._(t`Description`) (with the t tagged template). Without the t tag, the string "Description" won't be extracted by the @lingui/cli extraction tool into the translation catalog. The equivalent code in EventsBasedObjectEditor.js:91 correctly uses i18n._(t`Description`).
Suggested change
| label={i18n._(`Description`)} | |
| label={i18n._(t`Description`)} |
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Improvements
Chores