Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| {(property.getType() === 'String' || | ||
| property.getType() === 'Number' || | ||
| property.getType() === 'ObjectAnimationName' || | ||
| property.getType() === 'KeyboardKey' || | ||
| property.getType() === 'MultilineString') && ( |
There was a problem hiding this comment.
🔴 Duplicate 'Default value' fields rendered for MultilineString properties
When a property has type 'MultilineString', two "Default value" editors are rendered simultaneously: a CompactSemiControlledTextField (from the condition on lines 575-579 which includes 'MultilineString') and a CompactTextAreaField (from the dedicated MultilineString block on lines 603-620). The old code at EventsBasedBehaviorOrObjectPropertiesEditor.js handled both with a single SemiControlledTextField using multiline={property.getType() === 'MultilineString'}. The refactor correctly added a separate CompactTextAreaField for multiline but forgot to remove 'MultilineString' from the first condition, causing a duplicate editor to appear.
| {(property.getType() === 'String' || | |
| property.getType() === 'Number' || | |
| property.getType() === 'ObjectAnimationName' || | |
| property.getType() === 'KeyboardKey' || | |
| property.getType() === 'MultilineString') && ( | |
| {(property.getType() === 'String' || | |
| property.getType() === 'Number' || | |
| property.getType() === 'ObjectAnimationName' || | |
| property.getType() === 'KeyboardKey') && ( |
Was this helpful? React with 👍 or 👎 to provide feedback.
| floatingLabelText={<Trans>Description</Trans>} | ||
| helperMarkdownText={i18n._( | ||
| <CompactTextAreaField | ||
| label={i18n._(`Description`)} |
There was a problem hiding this comment.
🟡 Missing t translation macro on Description label in EventsBasedBehaviorEditor
At EventsBasedBehaviorEditor.js:106, the label uses i18n._(`Description`) instead of i18n._(t`Description`). Without the t macro, the lingui extractor won't pick up this string for translation, so the "Description" label will remain untranslated in non-English locales. All other labels in the same file correctly use i18n._(t...).
| label={i18n._(`Description`)} | |
| label={i18n._(t`Description`)} |
Was this helpful? React with 👍 or 👎 to provide feedback.
* Sticker3DBehavior * small fix * offset modes * fix destroy checkbox * 01 (#22) * 3dstickerpro (#20) * Sticker3DBehavior * small fix * offset modes * fix destroy checkbox * 3dstickerpro (#21) * Sticker3DBehavior * small fix * offset modes * fix destroy checkbox * Fix a crash updating an extension when importing a GDO file and the extension tab is open (4ian#8412) - Don't show in changelog * Fix potential crashes of the Objects panel (4ian#8413) * Add Ctrl/Cmd+K as a secondary shortcut for command palette (4ian#8415) * Remove useless wiki search integration from the Command Palette (4ian#8416) * Fix embedded resource links when importing a GDO (4ian#8419) * Display better certificate errors (4ian#8421) * Fix native menu wrongly shown when right clicking a tab on the web-app * Fix native context menu wrongly shown in Events Sheets on the web-app * Fix a crash when removing a behavior while the behavior overriding is displayed in the side panel (4ian#8427) * Redesign the object/behavior configuration editor in extensions to be more compact (4ian#8425) * Update the tree of functions in extensions editor with a new set of icons (4ian#8424) * [Auto PR] Update translations (4ian#8382) * Bump to 262 (4ian#8428) * Save the scroll position of JS code events when closing and opening tabs (4ian#8417) * Add a preference to enable the display of type errors in JavaScript events (4ian#8429) * Replace SearchBar with CompactSearchBar in property and function lists (4ian#8430) --------- Co-authored-by: D8H <Davy.Helard@gmail.com> Co-authored-by: Florian Rival <Florian.rival@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Clément Pasteau <4895034+ClementPasteau@users.noreply.github.com> --------- Co-authored-by: D8H <Davy.Helard@gmail.com> Co-authored-by: Florian Rival <Florian.rival@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Clément Pasteau <4895034+ClementPasteau@users.noreply.github.com>
4 participants
Uh oh!
There was an error while loading. Please reload this page.