Improve multibyte_split performance - #11347
Merged
rapids-bot[bot] merged 4 commits intoJul 26, 2022
Merged
Conversation
cwharris
added
improvement
bdice
reviewed
Jul 26, 2022
harrism
approved these changes
Jul 26, 2022
bdice
approved these changes
Jul 26, 2022
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #11347 +/- ##
=============================================
Coverage 86.37% 86.37%
=============================================
Files 143 143
Lines 22753 22746 -7
=============================================
- Hits 19653 19647 -6
+ Misses 3100 3099 -1
Continue to review full report at Codecov.
|
ttnghia
reviewed
Jul 26, 2022
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve's the performance of
multibyte_splitby converting one giantget_next_chunkread in to multiple smallerget_next_chunkreads, preventing the pinned host memory buffer from resizing, which was taking a very long time.before:
after: