Convert libcudf resource parameters to rmm::device_async_resource_ref - #15507
Conversation
|
It looks like there are some unrelated CI changes in the diff. Could you take a peek? |
Fixed with a merge. |
|
I have added some guidance for reviewers to the description. |
|
|
||
| /** | ||
| * @copydoc cudf::contains(column_view const&, column_view const&, rmm::mr::device_memory_resource*) | ||
| * @copydoc cudf::contains(column_view const&, column_view const&, rmm::device_async_resource_ref ) |
There was a problem hiding this comment.
A lot of these docstrings have an extra space at the end after rmm::device_async_resource_ref. Can we fix that? e.g.
| * @copydoc cudf::contains(column_view const&, column_view const&, rmm::device_async_resource_ref ) | |
| * @copydoc cudf::contains(column_view const&, column_view const&, rmm::device_async_resource_ref) |
|
Thank you for the reviews. @bdice thoughts on whether we should proceed with merging this out of sync with other repos? I kind of want to wait until I have a bit more confident progress on other repos, especially RAFT, which is proving kind of tricky. |
I'm somewhat inclined to merge sooner, given the scope of this change and its potential for conflicts. It would also be nice to have a large RAPIDS repository using the new code paths, to ensure that it's working as intended. However, if you want to wait, I'm okay with that. |
|
I got the RAFT changes working. Whether they like them is a different matter. But I agree, this PR looks pretty clean and safe, it is reviewed, and at risk of a lot of conflicts, so let's go ahead and merge |
|
/merge |
Description
Closes #15498
For reviewers:
Almost all of the thousands of changes are simple textual replace of
rmm::mr::device_memory_resource *withrmm::device_async_resource_ref.I think the only substantial changes that are different are in
contiguous_split.cu(which was assigningnullptrto the MR pointer -- I have changed these cases to use astd::optional<rmm::device_async_resource_ref>), and in JNI code.I still need to figure out how to build and test the JNI bindings. And figure out necessary Cython changes.JNI is passing CI now. Cython required no changes.
Checklist