Skip to content

Work around issues with cccl main - #15552

Merged
raydouglass merged 49 commits into
NVIDIA:branch-24.06from
miscco:fix_cccl_compat
May 28, 2024
Merged

Work around issues with cccl main#15552
raydouglass merged 49 commits into
NVIDIA:branch-24.06from
miscco:fix_cccl_compat

Conversation

@miscco

@miscco miscco commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

This gets cuDF build cccl main on 12.3.

There is one issue with the cuco tuple helpers but that will be fixed on the cuco side

@miscco
miscco requested a review from a team as a code owner April 17, 2024 16:09
@miscco
miscco requested review from bdice and ttnghia April 17, 2024 16:09
@github-actions github-actions Bot added the libcudf Affects libcudf (C++/CUDA) code. label Apr 17, 2024
Comment thread cpp/src/io/comp/statistics.cu Outdated
Comment thread cpp/src/io/parquet/page_string_decode.cu Outdated
@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 17, 2024
@ttnghia

ttnghia commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

/ok to test

@bdice

bdice commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

@miscco I went ahead and applied my two (small) suggestions, so we can get CI run and merge this sooner. These aren't controversial changes so we should be able to move this forward.

@bdice

bdice commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

/ok to test

@ttnghia

ttnghia commented Apr 19, 2024

Copy link
Copy Markdown
Contributor

/ok to test

@trxcllnt

Copy link
Copy Markdown
Member

/ok to test

@trxcllnt

trxcllnt commented May 8, 2024

Copy link
Copy Markdown
Member

@miscco I'm using this branch in NVIDIA/cccl#1667, will be updating this branch until that PR can build cudf.

@miscco
miscco requested a review from a team as a code owner May 8, 2024 20:03
Comment thread cpp/src/io/orc/reader_impl_decode.cu Outdated
Comment thread cpp/src/io/parquet/page_string_decode.cu Outdated
Comment thread rapids_config.cmake Outdated
rapids-bot Bot pushed a commit to rapidsai/cuspatial that referenced this pull request May 25, 2024
Similar to NVIDIA/cudf#15552, we are testing [building RAPIDS with CCCL's main branch](NVIDIA/cccl#1667) to get ahead of any breaking changes.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #1382
@raydouglass
raydouglass merged commit 29429f7 into NVIDIA:branch-24.06 May 28, 2024
@miscco
miscco deleted the fix_cccl_compat branch May 28, 2024 13:17
rapids-bot Bot pushed a commit to NVIDIA/cuml that referenced this pull request May 29, 2024
Similar to NVIDIA/cudf#15552, we are testing [building RAPIDS with CCCL's main branch](NVIDIA/cccl#1667) to get ahead of any breaking changes.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)
  - Dante Gama Dessavre (https://github.com/dantegd)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: #5886
rapids-bot Bot pushed a commit to rapidsai/cugraph that referenced this pull request May 29, 2024
Similar to NVIDIA/cudf#15552, we are testing [building RAPIDS with CCCL's main branch](NVIDIA/cccl#1667) to get ahead of any breaking changes.

Authors:
  - Paul Taylor (https://github.com/trxcllnt)
  - Ralph Liu (https://github.com/nv-rliu)
  - Seunghwa Kang (https://github.com/seunghwak)
  - Ray Bell (https://github.com/raybellwaves)

Approvers:
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Seunghwa Kang (https://github.com/seunghwak)
  - Jake Awe (https://github.com/AyodeAwe)

URL: #4404
rapids-bot Bot pushed a commit to rapidsai/rapids-cmake that referenced this pull request Jun 7, 2024
Updates CCCL to v2.5.0 and a more recent cuCollections commit.

Using cuco at [6923b3](NVIDIA/cuCollections@6923b3b) because it was before NVIDIA/cuCollections#479, which is a breaking change for libcudf.

CCCL PR:
* NVIDIA/cccl#1667

RAPIDS PRs:
* NVIDIA/cudf#15552
* NVIDIA/cuml#5886
* rapidsai/cugraph#4404
* rapidsai/cuspatial#1382

Authors:
  - Paul Taylor (https://github.com/trxcllnt)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Robert Maynard (https://github.com/robertmaynard)
  - Bradley Dice (https://github.com/bdice)

URL: #607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants