Fixing empty null lists throwing explode_outer for a loop. - #7649
Merged
rapids-bot[bot] merged 6 commits intoMar 24, 2021
Merged
Conversation
… a test for this case.
hyperbolic2346
added
3 - Ready for Review
…ode_outer_fix_empty
…ode_outer_fix_empty
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #7649 +/- ##
===============================================
+ Coverage 81.86% 82.48% +0.61%
===============================================
Files 101 101
Lines 16884 17426 +542
===============================================
+ Hits 13822 14373 +551
+ Misses 3062 3053 -9
Continue to review full report at Codecov.
|
ttnghia
reviewed
Mar 22, 2021
ttnghia
requested changes
Mar 23, 2021
mythrocks
reviewed
Mar 23, 2021
mythrocks
reviewed
Mar 23, 2021
mythrocks
reviewed
Mar 23, 2021
ttnghia
approved these changes
Mar 24, 2021
mythrocks
approved these changes
Mar 24, 2021
mythrocks
left a comment
mythrocks
left a comment
Contributor
There was a problem hiding this comment.
Apologies for the delayed review. It took me some time to grok the logic in the combined loop.
LGTM, at last!
Contributor
Author
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found two issues, one was that we didn't build the correct number of null or empty offsets. We should build them for the exploded column and they are sized as such, but I was marching over it the size of the child data column. This didn't cause trouble as long as there was more data than nulls.
The second issue was the large loop. We have to go over that loop at least the number of nulls we have as that loop is doing two things at once.
This was another case of things working fine as long as we ran the loop enough to cover all the null entries, which happens unless there are more nulls than entries. That wasn't tested and so it was never seen. Thankfully, @sperlingxx tested exactly that.
Added a test for this case.
Fixes #7636