Skip to content

Fix returned column type when extracting from an empty list column - #8025

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-0.20from
jlowe:fix-empty-list-extract
Apr 22, 2021
Merged

Fix returned column type when extracting from an empty list column#8025
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-0.20from
jlowe:fix-empty-list-extract

Conversation

@jlowe

@jlowe jlowe commented Apr 21, 2021

Copy link
Copy Markdown
Contributor

Fixes #8024

Fixes cudf::lists::extract_list_element to return an empty column of the list's child column type when the list column is empty.

@jlowe jlowe added bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Apr 21, 2021
@jlowe jlowe self-assigned this Apr 21, 2021
@jlowe
jlowe requested a review from a team as a code owner April 21, 2021 23:10
@jlowe
jlowe requested review from cwharris and ttnghia April 21, 2021 23:10
@codecov

codecov Bot commented Apr 22, 2021

Copy link
Copy Markdown

Codecov Report

Merging #8025 (d244e64) into branch-0.20 (51336df) will decrease coverage by 0.34%.
The diff coverage is 88.67%.

❗ Current head d244e64 differs from pull request most recent head 11937d0. Consider uploading reports for the commit 11937d0 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #8025      +/-   ##
===============================================
- Coverage        82.88%   82.54%   -0.35%     
===============================================
  Files              103      103              
  Lines            17668    17351     -317     
===============================================
- Hits             14645    14323     -322     
- Misses            3023     3028       +5     
Impacted Files Coverage Δ
python/cudf/cudf/core/column/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/io/orc.py 86.80% <ø> (-0.10%) ⬇️
python/cudf/cudf/utils/cudautils.py 55.04% <25.00%> (-2.72%) ⬇️
python/cudf/cudf/utils/dtypes.py 83.22% <50.00%> (-0.22%) ⬇️
python/cudf/cudf/core/column/numerical.py 94.41% <70.00%> (-0.02%) ⬇️
python/cudf/cudf/core/column/column.py 88.48% <75.00%> (-0.17%) ⬇️
python/cudf/cudf/core/column/decimal.py 90.08% <78.26%> (-2.85%) ⬇️
python/dask_cudf/dask_cudf/backends.py 89.20% <80.00%> (-0.38%) ⬇️
python/cudf/cudf/core/dataframe.py 90.75% <83.33%> (-0.11%) ⬇️
python/cudf/cudf/utils/utils.py 89.94% <95.00%> (+0.43%) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d64c0...11937d0. Read the comment docs.

@kkraus14

Copy link
Copy Markdown
Contributor

@gpucibot merge

@rapids-bot
rapids-bot Bot merged commit 069bf96 into NVIDIA:branch-0.20 Apr 22, 2021
@jlowe
jlowe deleted the fix-empty-list-extract branch September 10, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Extracting element from empty list column returns incorrectly typed column

4 participants