Fix returned column type when extracting from an empty list column - #8031
Merged
Conversation
jlowe
added
bug
jlowe
requested review from
devavret and
harrism
and removed request for
a team
April 22, 2021 13:25
kkraus14
added
the
! - Hotfix
jrhemstad
approved these changes
Apr 22, 2021
ttnghia
approved these changes
Apr 22, 2021
Contributor
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-0.19 #8031 +/- ##
============================================
Coverage 82.74% 82.74%
============================================
Files 103 103
Lines 17702 17702
============================================
Hits 14648 14648
Misses 3054 3054
Continue to review full report at Codecov.
|
mythrocks
approved these changes
Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
cudf::lists::extract_list_elementto return an empty column of the list's child column type when the list column is empty.This is the same change as #8025 picked for the 0.19.1 release.