Support scattering list_scalar - #8256
Merged
rapids-bot[bot] merged 18 commits intoMay 24, 2021
Merged
Conversation
github-actions
Bot
added
CMake
isVoid
added
2 - In Progress
harrism
changed the title
list_scalarlist_scalar
isVoid
marked this pull request as ready for review
May 18, 2021 06:48
isVoid
added
3 - Ready for Review
davidwendt
approved these changes
May 18, 2021
davidwendt
requested changes
May 18, 2021
davidwendt
left a comment
davidwendt
left a comment
Contributor
There was a problem hiding this comment.
Please remove the debug code. I believe scatter is used as a primitive in other cudf algorithms. This code will be difficult to maintain and frustrating to ignore when not specifically debugging this scatter. It also increases the size of the debug version of libcudf.so which is already getting to be too large for the debugger.
…scatter_list_scalars
…atter_list_scalars
davidwendt
reviewed
May 19, 2021
Co-authored-by: David Wendt <45795991+davidwendt@users.noreply.github.com>
Contributor
Author
|
rerun tests |
davidwendt
approved these changes
May 20, 2021
…scatter_list_scalars
ttnghia
requested changes
May 20, 2021
ttnghia
approved these changes
May 20, 2021
isVoid
added
5 - Ready to Merge
Contributor
Author
|
Looks like there are some failed tests, investigating. |
isVoid
added
0 - Waiting on Author
Contributor
Author
|
Welp, I broke the column scatter interface during the refactor. Should be fixed. |
isVoid
added
5 - Ready to Merge
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8256 +/- ##
===============================================
Coverage ? 82.88%
===============================================
Files ? 105
Lines ? 17874
Branches ? 0
===============================================
Hits ? 14814
Misses ? 3060
Partials ? 0 Continue to review full report at Codecov.
|
Contributor
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for scattering
list_scalarinto aLISTcolumn.This PR refactors current scatter for
LISTcolumn interface and allows column and scalar scatter share the same code path.This PR also removes all debugging codes in
scatter.cuh