Fix struct binary search and struct flattening - #8268
Merged
rapids-bot[bot] merged 13 commits intoMay 24, 2021
Conversation
… the children columns for null
…hould have the same null order as their parent column
harrism
suggested changes
May 18, 2021
jrhemstad
reviewed
May 18, 2021
Codecov Report
@@ Coverage Diff @@
## branch-21.06 #8268 +/- ##
===============================================
Coverage ? 82.89%
===============================================
Files ? 105
Lines ? 17875
Branches ? 0
===============================================
Hits ? 14818
Misses ? 3057
Partials ? 0 Continue to review full report at Codecov.
|
revans2
approved these changes
May 18, 2021
revans2
left a comment
Contributor
There was a problem hiding this comment.
From my perspective things look good. I have rerun tests and they pass.
jrhemstad
approved these changes
May 24, 2021
harrism
approved these changes
May 24, 2021
Contributor
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several bugs. In particular:
Unit tests for struct binary search and struct sorting are also rewritten.
Closes #8189.